Page MenuHomePhabricator

MUL - Fix mobile termbox styles for present/missing labels/descriptions
Closed, ResolvedPublic5 Estimated Story Points

Description

The mobile termbox sometimes shows missing labels or descriptions as if they were present. This can be reproduced e.g. on Q57591 when logged out (e.g. private window).

image.png (413×938 px, 48 KB)

This seems to be based on the no-JS termbox elements, which get reused for different languages without properly adjusting the classes:

image.png (291×938 px, 32 KB)

Steps to reproduce:
In a private window, and probably from a German IP address:

Acceptance criteria:

  • We understand the problem that leads to this issue.
  • The problem is solved (or if solving the problem is out of scope then please create a follow-up task so we can discuss it)

Notes:

  • This task was split out of T311617, since it seems technically unrelated.

Event Timeline

Change 834051 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova):

[wikibase/termbox@master] Update README to include UniversalLanguageSelector requirement

https://gerrit.wikimedia.org/r/834051

Change 834051 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova):

[wikibase/termbox@master] Update README to include UniversalLanguageSelector requirement

https://gerrit.wikimedia.org/r/834051

See also T218291: Model ULS dependency and T289061: Avoid using ULS in termbox.

Change 834051 merged by jenkins-bot:

[wikibase/termbox@master] Update README to include UniversalLanguageSelector requirement

https://gerrit.wikimedia.org/r/834051

@Lucas_Werkmeister_WMDE and I suspect that this task is closely related to T311617 and T311626, since the styles are incorrectly applied when first the no-js version is loaded and then the js version is loaded with different content and the styles stay in place but the languages get reordered.
Will move this task back to the parents/waiting column and this needs to be rechecked once both of these tasks are merged.

Still happens on Test Wikidata on wmf.4, so I’m afraid this didn’t get fixed by the changes for the other issues.

Change 843469 had a related patch set uploaded (by Hoo man; author: Hoo man):

[wikibase/termbox@master] Don't attempt to hydrate the DOM

https://gerrit.wikimedia.org/r/843469

I managed to reproduce this locally, and after some poking I managed to nail this down to: https://github.com/vuejs/core/issues/5063

Change 843469 merged by jenkins-bot:

[wikibase/termbox@master] Don't attempt to hydrate the DOM

https://gerrit.wikimedia.org/r/843469

Change 843928 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Update Termbox (don’t hydrate DOM)

https://gerrit.wikimedia.org/r/843928

By the way, we noticed that this isn’t limited to mul: https://m.wikidata.org/wiki/Q7362?uselang=bar

image.png (484×1 px, 104 KB)

(Item found with haslabel:bar -haslabel:de, since ULS insists I must speak Bavarian when I’m not logged in.)

Change 843928 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update Termbox (don’t hydrate DOM)

https://gerrit.wikimedia.org/r/843928

By the way, we noticed that this isn’t limited to mul: https://m.wikidata.org/wiki/Q7362?uselang=bar

image.png (484×1 px, 104 KB)

(Item found with haslabel:bar -haslabel:de, since ULS insists I must speak Bavarian when I’m not logged in.)

This looks fixed now as far as I can tell. (Though I’m a bit surprised the German label hasn’t been restored in over a week, actually.)

image.png (484×1 px, 49 KB)

Manuel subscribed.

Resolved! \o/