Page MenuHomePhabricator

Cannot manually log in on mobile Wikidata (real or test)
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

What should have happened instead?:

  • I should have been sent to m.wikidata.org / test.m.wikidata.org directly

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • I’m using Firefox Developer Edition 104.0.2 on Ubuntu 22.04 Jammy Jellyfish.
  • This may be related to other tasks like T225814 and T257852, but IIUC both of them are about “automatic” login (if you’re already logged in on the non-mobile site, and/or on another Wikimedia wiki?), not about “manual” login.

Event Timeline

Is this the same as T49647 for a different wiki? We have a hack (actually, a “hack” and a “better hack”) for that issue in production, for Commons and Meta, but not any Wikidata. Maybe we need to add it? (I happened to see that hack while working on T333926.)

Change 905642 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/mediawiki-config@master] Extend mobile login hack for Wikidata

https://gerrit.wikimedia.org/r/905642

Change 905642 abandoned by Lucas Werkmeister (WMDE):

[operations/mediawiki-config@master] Extend mobile login hack for Wikidata

Reason:

I tested this on mwdebug2001 and it didn’t seem to work. It’s possible that I did something wrong, but at least this doesn’t look like the quick fix I thought it might be.

https://gerrit.wikimedia.org/r/905642

fwiw, this also appears to occur for logins to all* mobile sites?


Tested:

  • test.m.wikipedia.org (i.e. ending up on test.wikipedia.org/wiki/Special:CentralLogin/complete?token= with error, but appears logged in)
  • en.m.wikipedia.org (i.e. ending up on en.wikipedia.org/wiki/Special:CentralLogin/complete?token= with error, but appears logged in)

Could https://gerrit.wikimedia.org/g/operations/mediawiki-config/+/4fddd1269809960b9a7faa0c480ca6a9d735d36e/wmf-config/CommonSettings.php#2767 have something to do with this?
Looks like there is no rules for wikidata so a little suspicious.

It didn’t seem like it when I tried it a while ago:

Change 905642 abandoned by Lucas Werkmeister (WMDE):

[operations/mediawiki-config@master] Extend mobile login hack for Wikidata

Reason:

I tested this on mwdebug2001 and it didn’t seem to work. It’s possible that I did something wrong, but at least this doesn’t look like the quick fix I thought it might be.

https://gerrit.wikimedia.org/r/905642

Is this the same as T49647 for a different wiki? We have a hack (actually, a “hack” and a “better hack”) for that issue in production, for Commons and Meta, but not any Wikidata. Maybe we need to add it? (I happened to see that hack while working on T333926.)

No, that issue is for *.wikimedia.org wikis, where we don't want to set cookies on wikimedia.org since it's used for other things than wikis, but setting cookies on the exact domain means x.wikimedia.org and x.m.wikimedia.org cannot share. For wikidata the cookies are set on wikidata.org so www.wikidata.org and www.m.wikidata.org can share them.

It probably does break things for other wikimedia.org wikis (wikimania etc) though.

matmarex assigned this task to Tgr.
matmarex subscribed.

Looks resolved by @Tgr's changes in T257852.