Page MenuHomePhabricator

Denylist for depict items that shouldn't be used
Open, LowPublicFeature

Description

Feature summary:
Create a server side Denylist of Wikidata Ids that should not be used for depict statements on Commons, e.g. ["Q123", "Q345", "Q678"].
For this initial version, we should just manually copy the MachineVision denylist.

Whenever a user tries to add depict statements, the server should check each Wikidata item to see if it's included in the denylist. If it is, the edit should not NOT be saved to Commons.

NOTE: For this first simple version, the end user will not get any notification that a depict statement was rejected. Another task will be added shortly to handle sending messages back to the client.

Benefits (why should this be implemented?):
This helps improve the quality of contributions using the ISA tool.
It will also serve as a basic framework for experimenting with more in depth rules, which could run on a schedule and be combined with our manually populated denylist.

Event Timeline

Sebastian_Berlin-WMSE renamed this task from Blacklist for depict items that shouldn't be used to Denylist for depict items that shouldn't be used.Sep 29 2022, 6:36 AM
Sebastian_Berlin-WMSE updated the task description. (Show Details)

I changed "blacklist" to "denylist", see T254646: Reconsidering how we name things. Also something to keep in mind in the code.

Thanks for fixing that @Sebastian_Berlin-WMSE!
Just had another look at this and realised some more detail at this stage would probably be helpful.
What do you think about creating a new table in the database for the Denylist? Especially as there are additional details which would be handy to store (and query for)

e.g. denylist table:

idwikidata_itemcategory
1Q10883

With separate denylist_categories table:

idnamereason
3colorsColors should never be added directly as a Depict statement. Add as a qualifier instead using the "color" property

We'd obviously need to mark the "reasons" for translation somehow, but I'm sure there are a few easy workarounds for that.

Change 838765 had a related patch set uploaded (by Eugene233; author: Eugene233):

[labs/tools/Isa@master] Denylist for depict items that shouldn't be used

https://gerrit.wikimedia.org/r/838765

Change 950013 had a related patch set uploaded (by Eugene233; author: Eugene233):

[labs/tools/Isa@m2c] Denylist for depict items that shouldn't be used

https://gerrit.wikimedia.org/r/950013

Change 838765 abandoned by Eugene233:

[labs/tools/Isa@master] Denylist for depict items that shouldn't be used

Reason:

In favor of https://gerrit.wikimedia.org/r/c/labs/tools/Isa/+/950013

https://gerrit.wikimedia.org/r/838765