Page MenuHomePhabricator

Regression: ArticleToolbar bottom border is too dark, and disappears in editing mode
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):
In T311311#8255574 __ @alexhollender_WMF reported:
@ovasileva @Jdlrobson @Esanders it seems like something changed here after I design reviewed it. The article toolbar (.mw-article-toolbar-container), in production, has: box-shadow: 0 1px #a2a9b1;

This means the border no longer matches the border beneath the VE toolbar, which was the main goal of this task. This also results in the tab underlines being difficult to see, which several community members have commented about. Compare:

design reviewed in betacurrently on production
Screen Shot 2022-09-23 at 8.58.32 AM.png (364×854 px, 54 KB)
Screen Shot 2022-09-23 at 8.58.51 AM.png (244×674 px, 18 KB)

Also, maybe related, when in editing mode there is no border beneath the toolbar:

Screen Shot 2022-09-23 at 8.24.50 AM.png (602×2 px, 237 KB)

Developer notes

This is likely a side effect of T317930 which had conflicting goals.

Event Timeline

Jdlrobson renamed this task from Regression: ArticleToolbar no longer consistent to Regression: ArticleToolbar no longer consistent with VE toolbar.Sep 29 2022, 5:11 PM
Jdlrobson set the point value for this task to 1.Sep 29 2022, 5:30 PM
alexhollender_WMF renamed this task from Regression: ArticleToolbar no longer consistent with VE toolbar to Regression: ArticleToolbar bottom border is too dark, and disappears in editing mode.Sep 29 2022, 5:52 PM

Seems fixable with a small CSS change to the color, and 1px additional margin. The margin is necessary due to the change from border to box shadow

Change 837157 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Fix page toolbar border

https://gerrit.wikimedia.org/r/837157

Change 836993 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.40.0-wmf.3] Fix page toolbar border

https://gerrit.wikimedia.org/r/836993

Please test on beta cluster.
Please move to needs more work or sign off.

Change 837157 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix page toolbar border

https://gerrit.wikimedia.org/r/837157

Change 836993 abandoned by Jdlrobson:

[mediawiki/skins/Vector@wmf/1.40.0-wmf.3] Fix page toolbar border

Reason:

No longer needed for Pixel

https://gerrit.wikimedia.org/r/836993