Maniphest T319363

Combobox expand button icon size is off
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Volker_E
	Oct 5 2022, 1:29 AM

Description

Background

In contrast to Select, Combobox's icon sizing is wrong.

On main:

Combobox	Select

Dev notes

Note that

there has already been close-by T303180, ~~so this might be a collateral regression~~.
.cdx-mixin-icon( center … ) is only used by Combobox right now, so it's safe to move forward with the mixin amendment.

Acceptance criteria for done

Fix expand button icon size
- Ensure no breakages in related components (see above)

Details

	Subject	Repo	Branch	Lines +/-
	Update Codex from v0.2.1 to v0.2.2	mediawiki/core	master	+1 K -1 K
	Combobox, styles: Fix expand button icon size	design/codex	main	+6 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		egardner	T298489 Add Combobox component to Codex
		Resolved		• DAbad	T319363 Combobox expand button icon size is off

Event Timeline

Volker_E created this task.Oct 5 2022, 1:29 AM

Volker_E added a project: CSS.

Volker_E updated the task description. (Show Details)

Volker_E updated the task description. (Show Details)Oct 5 2022, 1:31 AM

Change 838285 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] Combobox, styles: Fix expand button icon size

https://gerrit.wikimedia.org/r/838285

gerritbot added a project: Patch-For-Review.Oct 5 2022, 1:55 AM

Volker_E claimed this task.Oct 5 2022, 1:58 AM

Volker_E updated the task description. (Show Details)

Volker_E set the point value for this task to 1.

Volker_E moved this task from Committed to Code Review on the Design-System-Team (Design-System-Sprint) board.

AnneT moved this task from Code Review to Design Sign-Off on the Design-System-Team (Design-System-Sprint) board.Oct 5 2022, 2:48 PM

Change 838285 merged by jenkins-bot:

[design/codex@main] Combobox, styles: Fix expand button icon size

https://gerrit.wikimedia.org/r/838285

Maintenance_bot removed a project: Patch-For-Review.Oct 5 2022, 3:29 PM

Volker_E updated the task description. (Show Details)Oct 5 2022, 6:11 PM

Volker_E reassigned this task from Volker_E to bmartinezcalvo.Oct 19 2022, 5:18 PM

bmartinezcalvo reassigned this task from bmartinezcalvo to • EUdoh-WMF.Oct 19 2022, 6:25 PM

bmartinezcalvo moved this task from Design Sign-Off to QTE Sign-off on the Design-System-Team (Design-System-Sprint) board.

The icon for Select and Combo box look the same to me!

Checked on Chrome v106, Firefox v105 and Safari v16.

Change 849191 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update Codex from v0.2.1 to v0.2.2

https://gerrit.wikimedia.org/r/849191

gerritbot added a project: Patch-For-Review.Oct 25 2022, 11:01 PM

Change 849191 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.2.1 to v0.2.2

https://gerrit.wikimedia.org/r/849191

Maintenance_bot removed a project: Patch-For-Review.Oct 26 2022, 12:30 AM

Volker_E reassigned this task from • EUdoh-WMF to • DAbad.Oct 26 2022, 1:42 AM

Volker_E added a subscriber: • EUdoh-WMF.

ldelench_wmf closed this task as Resolved.Dec 7 2022, 9:54 PM

Volker_E moved this task from Product Sign-Off to Pending Release on the Design-System-Team (Design-System-Sprint) board.Feb 13 2023, 5:41 PM

	F35547155: image.png
	Oct 5 2022, 1:30 AM

Combobox expand button icon size is offClosed, ResolvedPublic1 Estimated Story PointsActions