Page MenuHomePhabricator

Add $2 parameter to message Mwe-upwiz-source-thirdparty-license
Closed, ResolvedPublic

Description

The message MediaWiki:Mwe-upwiz-source-thirdparty-license ends with the word "license(s)" which should be avoided by adding another parameter:
$2 - number of items in the list following the message.

I tried to amend the source myself but was unable to spot the place where the message is being used in the svn repository.

See also http://www.mediawiki.org/wiki/I18n#Pass_number_of_list_items_as_parameters_to_messages_talking_about_lists


Version: unspecified
Severity: trivial
URL: http://www.mediawiki.org/wiki/I18n#Pass_number_of_list_items_as_parameters_to_messages_talking_about_lists

Details

Reference
bz29964

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Low.
bzimport set Reference to bz29964.
bzimport added a subscriber: Unknown Object (MLST).

I'm not sure we need to have a plural version of this message--can the user select more than one license? It seems to me like the license chooser uses radio buttons, so....

If someone is going to delve into this, Purodha is correct, mwe-upwiz-source-thirdparty-license needs to use the {{PLURAL}} syntax for the number of licenses, and it's probably getting used at around line 382 of resources/mw.UploadWizardDeed.js, near the top of the declaration of mw.UploadWizardDeedChooser. The line looks like "gM( 'mwe-upwiz-source-' + deed.name, _this.uploads.length )" right now.

Marking as easy because it would just be adding a parameter.

Thehelpfulonewiki wrote:

Reassigning to wikibugs-l per bug 37789

Rjain added a comment.Jan 17 2013, 6:28 PM

Line 383 of resources/mw.UploadWizardDeed.js uses 'mwe-upwiz-source-'+deed.name (eg mwe-upwiz-source-thirdparty) but not 'mwe-upwiz-source-'+deed.name+'license' (eg mwe-upwiz-source-thirdparty-license) and i couldn't determine where the message 'mwe-upwiz-source-thirdparty-license' is being used . Is it used or not?

(In reply to comment #3)

Is it used or not?

you can do a grep for that.

(In reply to comment #3)

Seems like you are right, and grep won't help either. This message seems to be no longer use. I recommend removing this message from .config and .18n

Rjain added a comment.Apr 3 2013, 5:28 PM

removed the message from i18n, its not being used in .config
https://gerrit.wikimedia.org/r/#/c/57322/

Thanks Richa for the patch.

Gilles moved this task from Untriaged to Done on the Multimedia board.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJan 6 2018, 12:17 PM