Page MenuHomePhabricator
Create Task
Maniphest T320668

Reduce TTL lowering effect and raise cache accuracy of CURRENT*/LOCAL* magic words
Closed, ResolvedPublic
Actions

Description

Many of these words (hour/day/week/year) can adjust the TTL based on whether the value will change, rather than a blind TTL.

This would let the TTL adjustment be raised well above 3600 for many words, boosting parser cache duration.

Details

SubjectRepoBranchLines +/-
parser: improve cache TTL accuracy for CURRENT*/LOCAL* magic wordsmediawiki/coremaster+267 -88
Customize query in gerrit

Related Objects

Event Timeline

aaron created this task.Oct 12 2022, 6:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2022, 6:10 PM
gerritbot added a comment.Oct 12 2022, 6:56 PM

Change 569628 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] parser: improve cache TTL accuracy for CURRENT*/LOCAL* magic words

https://gerrit.wikimedia.org/r/569628

gerritbot added a project: Patch-For-Review.Oct 12 2022, 6:56 PM
Krinkle moved this task from Backlog to ParserCache/ParserOutputAccess on the MediaWiki-Parser board.Oct 17 2022, 6:51 PM
Krinkle added a project: Parsoid.
Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.
Krinkle moved this task from Limbo to Perf recommendation on the Performance-Team (Radar) board.
• JMcLeod_WMF edited projects, added Content-Transform-Team-WIP; removed Parsoid.Nov 10 2022, 3:23 PM
• JMcLeod_WMF moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.
cscott subscribed.Dec 12 2022, 4:08 PM

Looks like we have a patch here and I'm willing to review & merge it, but it's currently failing CI. If it gets cleaned up (or do you need me to do that) I'm happy to take it the rest of the way.

aaron added a comment.Dec 14 2022, 10:52 PM

Just a merge conflict. I rebased it.

• JMcLeod_WMF moved this task from Code Review to Blocked on the Content-Transform-Team-WIP board.Jan 23 2023, 4:08 PM
cscott added a subscriber: • tstarling.Feb 6 2023, 4:06 PM

There are some fundamental concerns raised by @tstarling on the patch, related to cache stampeding.

cscott mentioned this in T327173: Parsoid should expose cache expiry via REST API.Feb 23 2023, 3:19 PM
gerritbot added a comment.Mar 29 2023, 2:31 AM

Change 569628 merged by jenkins-bot:

[mediawiki/core@master] parser: improve cache TTL accuracy for CURRENT*/LOCAL* magic words

https://gerrit.wikimedia.org/r/569628

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.3; 2023-04-03).Mar 29 2023, 3:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 29 2023, 3:10 AM
matej_suchanek mentioned this in T51803: Calculated Age of persons can become outdated until next cache purge.Mar 29 2023, 8:08 AM
cscott mentioned this in T329067: Parsoid doesn't support the MagicWordFactory->getCacheTTL().Mar 29 2023, 1:43 PM
dr0ptp4kt moved this task from Blocked to To Deploy on the Content-Transform-Team-WIP board.Apr 3 2023, 3:25 PM
dr0ptp4kt moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.
cscott closed this task as Resolved.Apr 3 2023, 3:26 PM

This one landed!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits