In T290464#8224432, @Tacsipacsi wrote:In T290464#8223642, @matmarex wrote:Also, I was just testing and realized that we don't have a dependency on the Echo extension, even though some features don't work with it. (Surprisingly the wiki doesn't crash, but you never receive notifications for your subscriptions.) However, Echo isn't bundled yet…
What about defaulting $wgDiscussionTools_topicsubscription and $wgDiscussionTools_autotopicsub to unavailable unless Echo is loaded? DiscussionTools makes sense even without topic subscriptions.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T317146 Expand the set of bundled extensions and skins in MediaWiki 1.40 | |||
| Resolved | None | T290464 Bundle DiscussionTools extension with MediaWiki | |||
| Resolved | Esanders | T322498 Make the optional Echo dependency work better |
Event Timeline
Comment Actions
Change 853983 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/DiscussionTools@master] Topic subscription feature is unavailable if Echo is not installed
Comment Actions
Change 853983 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Topic subscription feature is unavailable if Echo is not installed
Comment Actions
I guess that works well enough. If you're a normal user, you won't notice anything mentioning topic subscriptions now (or at least I didn't when I tested this in this demo: https://patchdemo.wmflabs.org/wikis/fe3816290a/wiki/Talk:Main_Page).
There are still some bits and pieces that are not completely removed (e.g. in the page HTML, or the API, or the Special:TopicSubscriptions page), but we probably don't want to make the code more complicated by fixing that.