Page MenuHomePhabricator

LBFactoryMulti.php: PHP Notice: Undefined index: s11
Closed, ResolvedPublic

Description

PHP Notice: Undefined index: s11
from /srv/mediawiki/php-1.40.0-wmf.8/includes/libs/rdbms/lbfactory/LBFactoryMulti.php(360)
#0 /srv/mediawiki/php-1.40.0-wmf.8/includes/libs/rdbms/lbfactory/LBFactoryMulti.php(360): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.40.0-wmf.8/includes/libs/rdbms/lbfactory/LBFactory.php(236): Wikimedia\Rdbms\LBFactoryMulti->reconfigure(array)
#2 /srv/mediawiki/php-1.40.0-wmf.8/maintenance/includes/Maintenance.php(1172): Wikimedia\Rdbms\LBFactory->autoReconfigure()
#3 /srv/mediawiki/php-1.40.0-wmf.8/extensions/DiscussionTools/maintenance/persistRevisionThreadItems.php(142): Maintenance->waitForReplication()
#4 /srv/mediawiki/php-1.40.0-wmf.8/extensions/DiscussionTools/maintenance/persistRevisionThreadItems.php(88): MediaWiki\Extension\DiscussionTools\Maintenance\PersistRevisionThreadItems->process(Wikimedia\Rdbms\SelectQueryBuilder, array)
#5 /srv/mediawiki/php-1.40.0-wmf.8/maintenance/includes/MaintenanceRunner.php(309): MediaWiki\Extension\DiscussionTools\Maintenance\PersistRevisionThreadItems->execute()
#6 /srv/mediawiki/php-1.40.0-wmf.8/maintenance/doMaintenance.php(85): MediaWiki\Maintenance\MaintenanceRunner->run()
#7 /srv/mediawiki/php-1.40.0-wmf.8/extensions/DiscussionTools/maintenance/persistRevisionThreadItems.php(185): require_once(string)
#8 /srv/mediawiki/multiversion/MWScript.php(120): require_once(string)
#9 {main}

https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-deploy-1-7.0.0-1-2022.11.07?id=p54AVIQBRsHAyp5JWSb_

(occurred in the maint. script for T315510)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Two things stand out:

  • autoReconfigure - this suggest it is likely fall-out from the new live depooling feature from T298485. Tagging DBA/@Ladsgroup as such.
  • s11 - This DB section has a somewhat odd exception that is more special than even labswiki by not being in Etcd.
CommonSettings
	// labtestwiki is a one-off test server, using a wmcs-managed database.  Cut
	// etcd out of the loop entirely for this one.
	$wgLBFactoryConf['sectionLoads']['s11'] = [ 'clouddb2002-dev' => 1 ];

Two likely solutions:

  • Move this hack to (also) be copied to the autoReconfigure callback (a few lines up in the same config file).
  • Recalculate the cost/benefit of this "one-off" server not being listed in Etcd. It has existed since ~2018 (T233236 and possibly a bit earlier). Possibly easier to move to Etcd and manage via dbctl going forward.

sigh. s11 should move into production eventually but that's for longer term. For now, let's just add the hack to the recounfigure callback

Change 854509 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[operations/mediawiki-config@master] Re-add s11 in db config reload callback

https://gerrit.wikimedia.org/r/854509

Marostegui triaged this task as Medium priority.Nov 11 2022, 2:38 PM
Marostegui moved this task from Triage to In progress on the DBA board.

Change 854509 merged by jenkins-bot:

[operations/mediawiki-config@master] Re-add s11 in db config reload callback

https://gerrit.wikimedia.org/r/854509

Mentioned in SAL (#wikimedia-operations) [2022-11-14T11:24:14Z] <ladsgroup@deploy1002> Started scap: Backport for [[gerrit:854509|Re-add s11 in db config reload callback (T322598)]]

Mentioned in SAL (#wikimedia-operations) [2022-11-14T11:24:34Z] <ladsgroup@deploy1002> ladsgroup and ladsgroup: Backport for [[gerrit:854509|Re-add s11 in db config reload callback (T322598)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-11-14T11:29:15Z] <ladsgroup@deploy1002> Finished scap: Backport for [[gerrit:854509|Re-add s11 in db config reload callback (T322598)]] (duration: 05m 01s)

Ladsgroup claimed this task.
Ladsgroup moved this task from In progress to Done on the DBA board.