Page MenuHomePhabricator

tokens: Add `background-position` option and decision token with value `center`
Closed, ResolvedPublic

Description

Background

As of v0.2.2, Codex features a design decision in background-position: center in

  • Checkbox and
  • Thumbnail

which is not covered by tokens yet.

Goal

Provide background-position option and decision token.

Acceptance criteria

Add token to Figma In DS design sync we've agreed that this is a dev-only token category, it will not be featured in Codex Figma resources.

  • Add token to Codex codebase

Event Timeline

Same questions as with T322705: Refine animation tokens: Add `infinite` as option and decision: will this token present other values? Do we want to document tokens that apply only to components (and are most likely not themeable) and that don't have any variants?

@Volker_E - can you please put an initial/proposed priority level on this task and move it to the Backlog column?
DST prioritization guidance

Volker_E triaged this task as Medium priority.Jan 24 2023, 6:27 AM
Volker_E updated the task description. (Show Details)

Change 882992 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] tokens: Add `background-position` token

https://gerrit.wikimedia.org/r/882992

ldelench_wmf raised the priority of this task from Medium to High.Jan 27 2023, 4:22 PM
Volker_E removed a project: Patch-For-Review.
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)

Change 882992 merged by jenkins-bot:

[design/codex@main] tokens: Add `background-position` token

https://gerrit.wikimedia.org/r/882992

Seems fine to skip QTE and Product sign-off for this single token addition. cc: @CCiufo-WMF

Change 889230 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v0.5.0 to v0.6.0

https://gerrit.wikimedia.org/r/889230

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/66d018802f/w

Change 889230 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.5.0 to v0.6.0

https://gerrit.wikimedia.org/r/889230

Volker_E claimed this task.

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/66d018802f/w/