Page MenuHomePhabricator
Create Task
Maniphest T323172

[S] Extra spacing around personal tools icon buttons on viewports below tablet
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To
ovasileva
Authored By
bwang
Nov 15 2022, 10:25 PM
Tags
Referenced Files
F35868463: Screen Recording 2022-12-15 at 9.50.16 AM.mov.gif
Dec 15 2022, 5:51 PM
F35839391: Screen Recording 2022-12-05 at 5.39.20 PM.mov.gif
Dec 6 2022, 2:14 AM
F35826041: image.png
Dec 1 2022, 12:08 AM
F35787701: Screen Shot 2022-11-16 at 4.14.14 PM.png
Nov 16 2022, 9:14 PM
F35787699: Screen Shot 2022-11-16 at 4.14.00 PM.png
Nov 16 2022, 9:14 PM
Subscribers
Aklapper
• alexhollender_WMF
bwang
Edtadros
Jdlrobson
• nray

Description

Visual regression introduced by T320101. More context

Steps to replicate the issue (include links if applicable):

What happens?:
Personal tools icon buttons have an additional 8px spacing.

What should have happened instead?:
There should be no additional spacing below 1000px

Screenshots comparing change to master prior to deployment of visual enhancements feature flag:
https://phab.wmfusercontent.org/file/data/qmaodi6qizxayjfvrrvc/PHID-FILE-ar7nmb7celobw52n5som/Screen_Shot_2022-11-15_at_11.53.40_AM.png
https://jmp.sh/qBcSfEA2

above 1000px (correct spacing)below 1000px (incorrect spacing)
Screen Shot 2022-11-16 at 4.14.00 PM.png (63×498 px, 6 KB)
Screen Shot 2022-11-16 at 4.14.14 PM.png (60×488 px, 6 KB)

QA Results - Beta

ACStatusDetails
1✅T323172#8445370

QA Results - Prod

ACStatusDetails
1✅T323172#8471703

Details

SubjectRepoBranchLines +/-
VISUAL CHANGE: Fix extra padding around icon buttons < tablet viewportsmediawiki/skins/Vectormaster+11 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

bwang created this task.Nov 15 2022, 10:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 15 2022, 10:25 PM
gerritbot added a comment.Nov 15 2022, 10:28 PM

Change 857026 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Fix extra padding around icon buttons below tablet viewports

https://gerrit.wikimedia.org/r/857026

gerritbot added a project: Patch-For-Review.Nov 15 2022, 10:28 PM
bwang added a parent task: T322673: Test VectorVisualEnhancementsNext flag.Nov 15 2022, 10:57 PM
Jdlrobson moved this task from Incoming to Search on the Desktop Improvements (Vector 2022) board.Nov 16 2022, 5:41 AM
Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Nov 16 2022, 5:45 AM
• alexhollender_WMF updated the task description. (Show Details)Nov 16 2022, 9:14 PM
ovasileva triaged this task as Medium priority.Nov 16 2022, 9:25 PM
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-2022-23-Q2); removed Web-Team-Backlog.Nov 16 2022, 9:30 PM
Jdlrobson mentioned this in T322673: Test VectorVisualEnhancementsNext flag.Nov 16 2022, 10:39 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.Nov 16 2022, 11:18 PM
Jdlrobson set the point value for this task to 1.Nov 16 2022, 11:19 PM
Jdlrobson edited parent tasks, added: T317632: [EPIC] Visual refinements pt2; removed: T322673: Test VectorVisualEnhancementsNext flag.Nov 23 2022, 4:06 PM
ovasileva renamed this task from Extra spacing around personal tools icon buttons on viewports below tablet to [S] Extra spacing around personal tools icon buttons on viewports below tablet.Nov 28 2022, 6:30 PM
ovasileva moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.
Jdlrobson moved this task from Ready for Development to Needs More Work on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.Nov 28 2022, 6:35 PM
Jdlrobson claimed this task.Nov 29 2022, 6:35 PM
Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.
Jdlrobson removed Jdlrobson as the assignee of this task.Nov 30 2022, 6:35 PM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.
Jdlrobson subscribed.
PatchDemoBot added a comment.Dec 1 2022, 12:07 AM

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/fad8fcc3c4/w

Jdlrobson assigned this task to • alexhollender_WMF.Dec 1 2022, 12:08 AM
Jdlrobson moved this task from Code Review to Design Review on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.
Jdlrobson added a subscriber: • nray.

During code review @nray noticed the above change also reduces the space between the search bar and create acccount

image.png (1×3 px, 232 KB)

I've created a patch demo for you to check. Let me know if it looks good by moving into needs more work or code review (and assigning to me)

bwang reassigned this task from • alexhollender_WMF to Jdlrobson.Dec 2 2022, 3:50 PM
bwang moved this task from Design Review to Needs More Work on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.
bwang added a subscriber: • alexhollender_WMF.
Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.Dec 5 2022, 6:36 PM
Jdlrobson reassigned this task from Jdlrobson to bwang.Dec 5 2022, 9:06 PM
Jdlrobson moved this task from Doing to Needs More Work on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.

(see Gerrit patch)

bwang removed bwang as the assignee of this task.Dec 5 2022, 9:09 PM
bwang moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.
gerritbot added a comment.Dec 5 2022, 10:01 PM

Change 857026 merged by jenkins-bot:

[mediawiki/skins/Vector@master] VISUAL CHANGE: Fix extra padding around icon buttons < tablet viewports

https://gerrit.wikimedia.org/r/857026

Maintenance_bot removed a project: Patch-For-Review.Dec 5 2022, 10:30 PM
Jdlrobson assigned this task to Edtadros.Dec 5 2022, 11:00 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.13; 2022-12-05).Dec 5 2022, 11:00 PM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.Dec 6 2022, 2:14 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to https://en.wikipedia.beta.wmflabs.org/wiki/Polar_bear?useskin=vector-2022
Reduce viewport below 1000px
What happens?:
✅ AC1: There should be no additional spacing below 1000px

Screen Recording 2022-12-05 at 5.39.20 PM.mov.gif (263×382 px, 90 KB)

Edtadros reassigned this task from Edtadros to ovasileva.Dec 15 2022, 5:51 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to https://en.wikipedia.org/wiki/Polar_bear?useskin=vector-2022
Reduce viewport below 1000px
What happens?:
✅ AC1: There should be no additional spacing below 1000px

Screen Recording 2022-12-15 at 9.50.16 AM.mov.gif (350×402 px, 162 KB)

Edtadros updated the task description. (Show Details)Dec 15 2022, 5:53 PM
ovasileva closed this task as Resolved.Dec 16 2022, 3:50 PM

looks good, resolving!

PatchDemoBot added a comment.Aug 7 2023, 1:50 PM

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/fad8fcc3c4/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits