Page MenuHomePhabricator

Quick View: Opening and scrolling quick view in a fixed window.
Closed, ResolvedPublic

Description

This ticket is a follow up to T306885 from which the scrolling behaviour was moved to this ticket.

Problem:
The quick view right now does not have its own independent scrolling behaviour. And so currently if the user scrolls to view more content of the preview (in cases when the preview goes off the screen), then the entire screen scrolls up which means some of the search results that users may not have noticed/looked through goes off the screen. Users would then have to scroll back up and find the result they want to check the preview for.

Solution:
Allow users to scroll preview independently of the search results so that search results do not move out of the screen unless the user explicitly scrolls in the search result area. Also scrolling in the search result area will not affect the position of the previously opened preview.

Scrolling behaviour:

  • Scenario 1: When the Search Preview is opened with the top of the screen components (advance search, top bar etc) still visible, place it in the position as shown in Figma. (Note that the top of the preview is top aligned with the search widget.)
    Special_Search (11).png (800×1 px, 112 KB)
    Note: If the preview was opened on a smaller screen it may overlap the search widget which is fine as long as it does not overlap search results.
  • Scenario 2: When the Search Preview is opened with the top of the screen components not visible on the screen, place it in the position as shown in Figma. (Note that in this case it uses the full length of the browser.)
    Special_Search (12).png (800×1 px, 113 KB)
  • If the user has opened the preview in Scenario 1 and then slides up the screen, slide the search preview up and expand its size to make use of the available space as shown in second image above.
  • If the user has opened the preview in Scenario 2 and then slides down the screen, move the search preview down and shrink its size as shown in the first image above.
  • The Search preview card length should match the height of the user's browser. Leave some padding between the preview card and the edges of the browser as shown in both figma links above.
  • Users should be able to scroll preview within the card and it should not affect the page scrolling. A scroll bar will be visible on the preview card.
  • Users should be able to scroll the search results independent to the preview i.e. if the preview is open it will stay visible until it is closed or another preview opened.

Event Timeline

Change 864848 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Opening and scrolling quick view in a fixed window.

https://gerrit.wikimedia.org/r/864848

Change 864848 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Opening and scrolling quick view in a fixed window.

https://gerrit.wikimedia.org/r/864848

@Sneha - I'll provide a separate comment for each scenario.

  • Scenario 1: When the Search Preview is opened with the top of the screen components (advance search, top bar etc) still

visible, place it in the position as shown in Figma. (Note that the top of the preview is top aligned with the search widget.)

Special_Search (11).png (800×1 px, 112 KB)

Note: If the preview was opened on a smaller screen it may overlap the search widget which is fine as long as it does not overlap search results.

(1) The position is slightly different than in Figma - the top of the preview is not top aligned with the search widget.
See the side-by-side comparison in the screenshots below:

Figmabetlabs
Screen Shot 2022-12-12 at 1.24.42 PM.png (1×2 px, 747 KB)
Screen Shot 2022-12-12 at 12.50.03 PM.png (1×3 px, 2 MB)

(2)

  • If the user has opened the preview in Scenario 1 and then slides up the screen, slide the search preview up and expand its size to make use of the available space as shown in second image above.

The gif below shows just scrolling from the top down (no other interaction):

scroll_from_top2.gif (731×1 px, 382 KB)

I think it looks acceptable. One of the edge cases - if an article doesn't have a picture and doesn't have sections, then its QuickView will expand without any reason to do so. Not sure if we should accommodate such an edge case.
The gif shows expanding QuickView white space - an article doesn't have an image and sections.

scroll_from_top3.gif (731×1 px, 1 MB)


Notes:

  • The width of QuickView depends on whether the side menu on Vector (2022) is expanded or collapsed:
Vector (2022) - menu collapsedVector (2022) expanded
Screen Shot 2022-12-12 at 12.52.58 PM.png (1×3 px, 1 MB)
Screen Shot 2022-12-12 at 12.53.14 PM.png (1×3 px, 1 MB)
  • Scenario 2: When the Search Preview is opened with the top of the screen components not visible on the screen, place it in the position as shown in Figma. (Note that in this case it uses the full length of the browser.)
    Special_Search (12).png (800×1 px, 113 KB)

This scenario looks fine - the gif below shows the opening (not the top image) and scrolling. The scrolling has the same behavior as scrolling in the Scenario 1.

scroll_from_top5.gif (731×1 px, 3 MB)

Hi @Etonkovidova

For scenario 1 comments:

#1 the alignment issue you pointed does not need to be resolved. I actually changed it in my wires but forgot to update the image here. It does not need to align to the search widget as it will overlap the number of search results copy. So this is good to go.

#2 yes there are some edge cases but otherwise it is working as expected.

Scenario 2 looks good to me too.

For the note on Narrow Quick view I think we can improve that but it is not part of this ticket. I will make a note of that and create a new ticket.

Checked on pilots wikis (wmf.18) - works as expected.