Page MenuHomePhabricator
Create Task
Maniphest T324366

Mismatch Finder: Adjust footer styles to match original designs
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
noarave
Authored By
Sarai-WMDE
Dec 2 2022, 8:38 PM
Tags
Referenced Files
F35870057: Screenshot 2022-12-16 at 12.11.59.png
Dec 16 2022, 11:12 AM
F35870052: Screenshot 2022-12-16 at 12.09.42.png
Dec 16 2022, 11:12 AM
F35829019: Screenshot 2022-12-02 at 21.41.32.png
Dec 2 2022, 8:42 PM
F35828999: Screenshot 2022-12-02 at 21.29.26.png
Dec 2 2022, 8:38 PM
Subscribers
Aklapper
Arian_Bozorg
Sarai-WMDE

Description

Problem

Some of the visual features of the Mismatch Finder footer (typographic styles, spacing on mobile) are not aligned with its original specifications. Adjusting this page area to the initial designs will also make it consistent with the footer of the similarly-structured Query Builder.

Mockups

FontsSpacing
Screenshot 2022-12-16 at 12.09.42.png (864×1 px, 172 KB)
Screenshot 2022-12-16 at 12.11.59.png (1×1 px, 111 KB)

Link to specifications in Figma

Acceptance criteria

  • Fonts: All the text elements included in the Mismatch Finder’s footer should have a font size of 14px (0.875em).
  • Spacing: When the link groups wrap in smaller screens, the sections of links should be spaced by 2rem ($dimension-layout-medium) between them

Related Objects
Search...

Event Timeline

Sarai-WMDE created this task.Dec 2 2022, 8:38 PM
Sarai-WMDE updated the task description. (Show Details)Dec 2 2022, 8:42 PM
Lydia_Pintscher moved this task from Incoming to Product Backlog on the Wikidata Dev Team board.Dec 2 2022, 8:53 PM
Lydia_Pintscher moved this task from Product Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Dec 5 2022, 3:36 PM
karapayneWMDE set the point value for this task to 3.Dec 13 2022, 10:46 AM
karapayneWMDE moved this task from Unified DOT Backlog to Sprint-∞ on the Wikidata Dev Team board.
karapayneWMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team.
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 14 2022, 1:14 PM
Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.
noarave claimed this task.Dec 16 2022, 9:49 AM
Restricted Application added a project: User-Noarave. · View Herald TranscriptDec 16 2022, 9:49 AM
noarave moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board.Dec 16 2022, 9:49 AM
Sarai-WMDE updated the task description. (Show Details)Dec 16 2022, 11:12 AM
noarave added a comment.Dec 16 2022, 12:08 PM

https://github.com/wmde/wikidata-mismatch-finder/pull/512

noarave moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Dec 16 2022, 12:11 PM
noarave moved this task from Peer Review to Product Verification on the Wikidata Dev Team (Sprint-∞) board.Dec 16 2022, 1:43 PM
Arian_Bozorg subscribed.Dec 19 2022, 1:51 PM

Thanks Noa!

This looks good to me :)

Arian_Bozorg closed this task as Resolved.Dec 19 2022, 1:51 PM
Arian_Bozorg moved this task from Product Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board.
karapayneWMDE moved this task from Our work done to 2022 Completed Tasks on the Wikidata Dev Team (Sprint-∞) board.Dec 20 2022, 8:15 PM
Arian_Bozorg mentioned this in T324356: Query Builder: Adjust footer content and style.Jan 5 2023, 2:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL