Page MenuHomePhabricator

Adoption request for jarbot (jarbot, jarbot-ii, jarbot-iii) & jarallah (jarallah, jarallah-ii)
Closed, ResolvedPublicSecurity

Description

I request being added as a co-maintainer of:

I do not believe this request is covered by the Adoption policy, however the bot/tool operator (https://wikitech.wikimedia.org/wiki/User:Jarbot & https://wikitech.wikimedia.org/wiki/User:Jarallah c/o https://meta.wikimedia.org/wiki/Special:CentralAuth/جار_الله) has been globally banned.

The bot tasks are listed at https://meta.wikimedia.org/wiki/User:JarBot.

Please could the TFSC :

  • check the tool's home directory for obvious secret information, following the Adoption policy instructions

Event Timeline

TheresNoTime set Security to Software security bug.Dec 6 2022, 7:18 PM
TheresNoTime changed the visibility from "Public (No Login Required)" to "Custom Policy".
TheresNoTime changed the subtype of this task from "Task" to "Security Issue".

Blocked 6 more accounts which shared the same email in LDAP.

Not sure whatt to do about the adoption request, however. None of the tools seem to have a license specified.

(when possible, please make this task public)

Urbanecm changed the visibility from "Custom Policy" to "Public (No Login Required)".Dec 6 2022, 7:35 PM

(when possible, please make this task public)

Done, as the accounts listed above are now disabled as well.

Not sure what to do about the adoption request, however. None of the tools seem to have a license specified.

For the records, a few weeks ago a coworker contacted its maintainer about license and source code. The maintainer's reply was that they have not made their code public yet or put it under any license yet.

Do we know where the code is located?

Do we know where the code is located?

None of these tool accounts include a Striker toolinfo declaring a default license. I think all of the scripts that do include license comments were copied from elsewhere.

For the records, among this year's nominations for the Coolest Tool Award (CTA) was also a nomination for JarBot. Thus the CTA committee reviewed the nomination and contacted its maintainer about license and source code. The maintainer's reply was that they have not made their code public yet or put it under any license yet.

Technically, that was an confession to violating the Toolforge's Rules (second point, "All code in the Tools project must be published under an OSI approved open source license"). Perhaps it would make sense to remind maintainers that use Toolforge about that when CTA committee asks for the license?

@Urbanecm: T271712 or T311293 might scale better for trying to encourage Toolforge rules (but someone needs to do it). :)

Wonderful :( Based on T324607#8449385, I'd recommend we just mark the tools for deletion. And maybe in 2023 do some kind of Toolforge-wide audit of licensing compliance...🤔

taavi claimed this task.

Marked all of those tools for deletion. I don't think there's anything more remaining that can be done here, unfortunately.