armorFrenchSpaces not applied in sidebar TOC in 2022 Vector skin
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Thibaut120094
	Dec 8 2022, 2:41 PM

Description

Steps to replicate the issue (include links if applicable):

Log out or enable the Vector 2022 skin in your preferences.
Go to any page on any French-language wiki that shows a table of contents with ? ! : ; « » in headings.
- Example: https://fr.wikipedia.org/w/index.php?title=Wikip%C3%A9dia:Le_Bistro/8_d%C3%A9cembre_2022&oldid=199326295

What happens?:
Normal spaces (U+0020) shown instead of non-breaking spaces (U+00A0) before ? ! : ; » and after «.

<span class="sidebar-toc-numb">2</span>Renommer la page « Informatique durable » en « Numérique responsable » ?</div>

Capture d’écran 2022-12-08 à 15.27.51.png (310×438 px, 41 KB)

What should have happened instead?:
Non-breaking spaces (U+00A0) should have been applied before ? ! : ; » and after « instead of normal spaces (U+0020).

<span class="sidebar-toc-numb">2</span>Renommer la page «&nbsp;Informatique durable&nbsp;» en «&nbsp;Numérique responsable&nbsp;»&nbsp;?</div>

Capture d’écran 2022-12-08 à 15.29.21.png (318×452 px, 41 KB)

Other information
The issue doesn't happen in the body of the page, where the non-breaking spaces are correctly applied in the headings:

<span id="Renommer_la_page_.C2.AB_Informatique_durable_.C2.BB_en_.C2.AB_Num.C3.A9rique_responsable_.C2.BB_.3F"></span><span class="mw-headline" id="Renommer_la_page_«_Informatique_durable_»_en_«_Numérique_responsable_»_?" data-mw-thread-id="h-Renommer_la_page_«_Informatique_durable_»_en_«_Numérique_responsable_»_?-20221208080700"><span data-mw-comment-start="" id="h-Renommer_la_page_«_Informatique_durable_»_en_«_Numérique_responsable_»_?-20221208080700"></span>Renommer la page «&nbsp;Informatique durable&nbsp;» en «&nbsp;Numérique responsable&nbsp;»&nbsp;?<span data-mw-comment-end="h-Renommer_la_page_«_Informatique_durable_»_en_«_Numérique_responsable_»_?-20221208080700"></span></span>

QA Results - Prod

AC	Status	Details
1	✅	T324763#9570306

Details

	Subject	Repo	Branch	Lines +/-
	Add parser tests for TOC behavior with french spacing and HTML entities	mediawiki/core	master	+48 -0
	Parser: Convert wikitext entities to HTML entities in TOC	mediawiki/core	master	+4 -0

Customize query in gerrit

Related Objects

Mentioned In: T356225: Verify 1.42.0-wmf.18 deployment
Mentioned Here: T355386: section name "F&GT" shows as "F<" in table of contents, edit summaries, and element ID
T303855: Page-wide language conversion rules are ignored in the ToC

Event Timeline

Thibaut120094 created this task.Dec 8 2022, 2:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 8 2022, 2:41 PM

Thibaut120094 renamed this task from armorFrenchSpaces not applied in TOC in 2022 Vector skin to armorFrenchSpaces not applied in sidebar TOC in 2022 Vector skin.Dec 8 2022, 2:46 PM

Thibaut120094 updated the task description. (Show Details)

Mathis_Benguigui subscribed.Dec 8 2022, 2:50 PM

Thibaut120094 updated the task description. (Show Details)Dec 8 2022, 2:52 PM

Thibaut120094 updated the task description. (Show Details)Dec 8 2022, 2:57 PM

Thibaut120094 added projects: Parsoid, Parsoid-Rendering.Dec 8 2022, 3:16 PM

• JMcLeod_WMF edited projects, added MediaWiki-Parser; removed Parsoid-Rendering, Parsoid.Dec 8 2022, 3:24 PM

cscott subscribed.Dec 8 2022, 3:24 PM

Not entirely unrelated to T303855: Page-wide language conversion rules are ignored in the ToC -- conversion and french spacing should be done on the SectionData json before that is stored in the ParserOutput.

Una_tantum subscribed.Dec 8 2022, 4:32 PM

Jdlrobson moved this task from Incoming to Work with other teams on the Desktop Improvements (Vector 2022) board.Dec 8 2022, 8:16 PM

Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Jan 5 2023, 9:30 PM

Jdlrobson moved this task from Not ready to estimate to Current Fiscal Year on the Web-Team-Backlog board.Jan 26 2023, 6:00 PM

Jdlrobson moved this task from Current Fiscal Year to Not ready to estimate on the Web-Team-Backlog board.Apr 10 2023, 6:01 PM

ovasileva triaged this task as Low priority.Apr 11 2023, 4:25 PM

Can replicate at 1292px

For "Renommer la page « Informatique durable » en « Numérique responsable » ?"

Screenshot 2023-12-04 at 9.45.29 AM.png (155×301 px, 13 KB)

Note: it breaks after "en <<", instead it should break after "en"

matmarex claimed this task.Jan 20 2024, 4:05 AM

Change 991877 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Parser: Convert wikitext entities to HTML entities in TOC

https://gerrit.wikimedia.org/r/991877

gerritbot added a project: Patch-For-Review.Jan 20 2024, 4:08 AM

(I found this task by accident when searching for bug reports similar to T355386, and realized that it's a different bug but the same root cause.)

Jdlrobson moved this task from Work with other teams to Tracking (Waiting on other teams) on the Desktop Improvements (Vector 2022) board.Feb 8 2024, 5:29 PM

Change 1002605 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Add parser tests for TOC behavior with french spacing and HTML entities

https://gerrit.wikimedia.org/r/1002605

Jdlrobson moved this task from Groomed to Tracking on the Web-Team-Backlog board.Feb 12 2024, 7:48 PM

Change 991877 merged by jenkins-bot:

[mediawiki/core@master] Parser: Convert wikitext entities to HTML entities in TOC

https://gerrit.wikimedia.org/r/991877

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.18; 2024-02-13).Feb 12 2024, 8:00 PM

Change 1002605 merged by jenkins-bot:

[mediawiki/core@master] Add parser tests for TOC behavior with french spacing and HTML entities

https://gerrit.wikimedia.org/r/1002605

matmarex closed this task as Resolved.Feb 12 2024, 9:16 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 12 2024, 9:33 PM

Test Result - Prod

Status: ✅ PASS
Environment: frwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Log out or enable the Vector 2022 skin in your preferences.
Go to any page on any French-language wiki that shows a table of contents with ? ! : ; « » in headings.
Example: https://fr.wikipedia.org/w/index.php?title=Wikip%C3%A9dia:Le_Bistro/8_d%C3%A9cembre_2022&oldid=199326295
❓ AC1: Non-breaking spaces (U+00A0) should have been applied before ? ! : ; » and after « instead of normal spaces (U+0020).
@Jdlrobson I cannot get the same TOC to appear as shown in the expected result in the task description.

<1000

width >=1200

1000<= width <1200

Edtadros updated the task description. (Show Details)Feb 22 2024, 10:13 PM

Edtadros mentioned this in T356225: Verify 1.42.0-wmf.18 deployment.

@Edtadros I can get the "expected results" with a browser-width of 1280px:

In any case the important thing is that the « isn't separated from the word before and !, », and ? aren't separated from the word before them.

	F41560315: Screenshot 2023-12-04 at 9.45.29 AM.png
	Dec 4 2023, 5:52 PM

	F35846179: Capture d’écran 2022-12-08 à 15.29.21.png
	Dec 8 2022, 2:41 PM

	F35846177: Capture d’écran 2022-12-08 à 15.27.51.png
	Dec 8 2022, 2:41 PM

	F42153784: image.png
	Feb 26 2024, 6:42 PM

	F42050167: screenshot 554.png
	Feb 22 2024, 10:12 PM

	F42050166: screenshot 553.png
	Feb 22 2024, 10:12 PM

	F42050165: screenshot 555.png
	Feb 22 2024, 10:12 PM

armorFrenchSpaces not applied in sidebar TOC in 2022 Vector skinClosed, ResolvedPublicBUG REPORTActions