Page MenuHomePhabricator
Create Task
Maniphest T324903

Deprecated: Creation of dynamic properties in FlaggedRevs
Closed, ResolvedPublic
Actions

Description

Outstanding:

Deprecated: Creation of dynamic property HistoryPager::$fr_stableRevId is deprecated in /var/www/wiki/mediawiki/extensions/FlaggedRevs/frontend/FlaggedRevsUIHooks.php on line 678

Deprecated: Creation of dynamic property HistoryPager::$fr_stableRevUTS is deprecated in /var/www/wiki/mediawiki/extensions/FlaggedRevs/frontend/FlaggedRevsUIHooks.php on line 679

Deprecated: Creation of dynamic property HistoryPager::$fr_pendingRevs is deprecated in /var/www/wiki/mediawiki/extensions/FlaggedRevs/frontend/FlaggedRevsUIHooks.php on line 681

Fixed:

Deprecated: Creation of dynamic property EditPage::$fr_baseRevId is deprecated in /var/www/wiki/mediawiki/core/includes/debug/DeprecationHelper.php on line 243

Deprecated: Creation of dynamic property EditPage::$fr_altBaseRevId is deprecated in /var/www/wiki/mediawiki/core/includes/debug/DeprecationHelper.php on line 243

Details

SubjectRepoBranchLines +/-
HistoryPager: Add #[AllowDynamicProperties]mediawiki/coreREL1_41+1 -0
HistoryPager: Add #[AllowDynamicProperties]mediawiki/coreREL1_40+1 -0
HistoryPager: Add #[AllowDynamicProperties]mediawiki/coreREL1_39+1 -0
HistoryPager: Add #[AllowDynamicProperties]mediawiki/coremaster+1 -0
EditPage: Add #[AllowDynamicProperties]mediawiki/coreREL1_39+1 -0
EditPage: Add #[AllowDynamicProperties]mediawiki/coremaster+1 -0
EditPage: Add #[AllowDynamicProperties]mediawiki/coreREL1_40+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Dec 10 2022, 7:20 PM
Reedy moved this task from Backlog to Wikimedia production on the PHP 8.2 support board.Dec 10 2022, 9:38 PM
Reedy renamed this task from Deprecated: Creation of dynamic property EditPage to Deprecated: Creation of dynamic properties on EditPage.Dec 11 2022, 4:20 PM
Reedy mentioned this in T326182: Deprecated: Creation of dynamic property is deprecated.Jan 3 2023, 10:11 PM
Reedy renamed this task from Deprecated: Creation of dynamic properties on EditPage to Deprecated: Creation of dynamic properties in FlaggedRevs.Jan 10 2023, 1:24 AM
Reedy updated the task description. (Show Details)
Ladsgroup subscribed.Jan 10 2023, 1:26 AM

/me coughs T185664: Code stewardship review: FlaggedRevs

gerritbot added a comment.Jul 25 2023, 7:08 PM

Change 941491 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] EditPage: Add #[AllowDynamicProperties]

https://gerrit.wikimedia.org/r/941491

gerritbot added a project: Patch-For-Review.Jul 25 2023, 7:08 PM
gerritbot added a comment.Jul 25 2023, 9:02 PM

Change 941491 merged by jenkins-bot:

[mediawiki/core@master] EditPage: Add #[AllowDynamicProperties]

https://gerrit.wikimedia.org/r/941491

gerritbot added a comment.Jul 25 2023, 9:03 PM

Change 941500 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_39] EditPage: Add #[AllowDynamicProperties]

https://gerrit.wikimedia.org/r/941500

gerritbot added a comment.Jul 25 2023, 9:03 PM

Change 941501 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_40] EditPage: Add #[AllowDynamicProperties]

https://gerrit.wikimedia.org/r/941501

gerritbot added a comment.Jul 25 2023, 9:15 PM

Change 941501 merged by jenkins-bot:

[mediawiki/core@REL1_40] EditPage: Add #[AllowDynamicProperties]

https://gerrit.wikimedia.org/r/941501

gerritbot added a comment.Jul 25 2023, 9:22 PM

Change 941500 merged by jenkins-bot:

[mediawiki/core@REL1_39] EditPage: Add #[AllowDynamicProperties]

https://gerrit.wikimedia.org/r/941500

Maintenance_bot removed a project: Patch-For-Review.Jul 25 2023, 9:31 PM
ReleaseTaggerBot added projects: MW-1.39-notes, MW-1.40-notes, MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 25 2023, 10:00 PM
matmarex subscribed.Aug 9 2023, 10:29 PM

There's an old pending patch that removes this, among other cleanup changes: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/329649. I wonder if anyone would like to revive it?

Jdforrester-WMF mentioned this in T352085: Make PHP 8.2 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries).Nov 27 2023, 7:36 PM
Reedy added a comment.Mar 20 2024, 4:53 PM
In T324903#9082234, @matmarex wrote:

There's an old pending patch that removes this, among other cleanup changes: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/329649. I wonder if anyone would like to revive it?

Manually rebased...

gerritbot added a comment.Mar 20 2024, 4:56 PM

Change 1013102 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] HistoryPager: Add #[AllowDynamicProperties]

https://gerrit.wikimedia.org/r/1013102

gerritbot added a project: Patch-For-Review.Mar 20 2024, 4:56 PM
Reedy updated the task description. (Show Details)Mar 20 2024, 5:59 PM
gerritbot added a comment.Mar 21 2024, 12:36 PM

Change 1013102 merged by jenkins-bot:

[mediawiki/core@master] HistoryPager: Add #[AllowDynamicProperties]

https://gerrit.wikimedia.org/r/1013102

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.24; 2024-03-26).Mar 21 2024, 1:00 PM
gerritbot added a comment.Mar 21 2024, 1:03 PM

Change 1013247 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_41] HistoryPager: Add #[AllowDynamicProperties]

https://gerrit.wikimedia.org/r/1013247

gerritbot added a comment.Mar 21 2024, 1:03 PM

Change 1013248 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_40] HistoryPager: Add #[AllowDynamicProperties]

https://gerrit.wikimedia.org/r/1013248

gerritbot added a comment.Mar 21 2024, 1:04 PM

Change 1013249 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_39] HistoryPager: Add #[AllowDynamicProperties]

https://gerrit.wikimedia.org/r/1013249

gerritbot added a comment.Mar 21 2024, 1:35 PM

Change 1013249 merged by jenkins-bot:

[mediawiki/core@REL1_39] HistoryPager: Add #[AllowDynamicProperties]

https://gerrit.wikimedia.org/r/1013249

gerritbot added a comment.Mar 21 2024, 1:37 PM

Change 1013247 merged by jenkins-bot:

[mediawiki/core@REL1_41] HistoryPager: Add #[AllowDynamicProperties]

https://gerrit.wikimedia.org/r/1013247

gerritbot added a comment.Mar 21 2024, 1:38 PM

Change 1013248 merged by jenkins-bot:

[mediawiki/core@REL1_40] HistoryPager: Add #[AllowDynamicProperties]

https://gerrit.wikimedia.org/r/1013248

ReleaseTaggerBot edited projects, added MW-1.41-notes; removed MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Mar 21 2024, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 21 2024, 2:31 PM
matmarex closed this task as Resolved.Mar 28 2024, 3:30 AM
In T324903#9646509, @Reedy wrote:
In T324903#9082234, @matmarex wrote:

There's an old pending patch that removes this, among other cleanup changes: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/329649. I wonder if anyone would like to revive it?

Manually rebased...

And it was merged. I guess that resolves this.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL