Page MenuHomePhabricator
Create Task
Maniphest T325190

💥️ Handle invalid and missing field errors for the PATCH endpoint
Closed, ResolvedPublic
Actions

Description

Same as T324592 and T324839, but for PATCH endpoints. Needs to wait until T325182 is done.

Details

SubjectRepoBranchLines +/-
REST: Report missing field errors for patched statementsmediawiki/extensions/Wikibasemaster+21 -6
REST: Remove unused error codesmediawiki/extensions/Wikibasemaster+8 -57
REST: Report invalid field errors for patched statementsmediawiki/extensions/Wikibasemaster+32 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Dec 14 2022, 3:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2022, 3:58 PM
Silvan_WMDE mentioned this in T325079: 💥️ Decide how to deal with missing/invalid field errors in patched statements.Dec 14 2022, 4:14 PM
Jakob_WMDE claimed this task.Dec 19 2022, 4:28 PM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 19) board.
gerritbot added a comment.Dec 20 2022, 11:39 AM

Change 869726 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: report invalid field errors for patched statements

https://gerrit.wikimedia.org/r/869726

gerritbot added a project: Patch-For-Review.Dec 20 2022, 11:39 AM
gerritbot added a comment.Dec 20 2022, 1:33 PM

Change 869756 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Report missing field errors for patched statements

https://gerrit.wikimedia.org/r/869756

gerritbot added a comment.Dec 20 2022, 1:42 PM

Change 869760 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Remove unused StatementValidator::CODE_INVALID

https://gerrit.wikimedia.org/r/869760

Muhammad_Yasser_Jazirahly_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 19) board.Dec 20 2022, 2:11 PM
gerritbot added a comment.Dec 21 2022, 9:31 AM

Change 869726 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Report invalid field errors for patched statements

https://gerrit.wikimedia.org/r/869726

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 21 2022, 10:00 AM
gerritbot added a comment.Dec 21 2022, 11:10 AM

Change 869756 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Report missing field errors for patched statements

https://gerrit.wikimedia.org/r/869756

gerritbot added a comment.Dec 21 2022, 11:10 AM

Change 869760 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove unused error codes

https://gerrit.wikimedia.org/r/869760

Ollie.Shotton_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 19) board.Dec 21 2022, 11:24 AM
Ollie.Shotton_WMDE removed a project: Patch-For-Review.Dec 22 2022, 5:16 PM
WMDE-leszek closed this task as Resolved.Jan 17 2023, 9:37 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL