Phabricator lists the Gerrit patches associated with a task, with icons indicating status such as comments or negative reviews (T229934: Enable semantic relationship between code review changesets and maniphest tasks in phabricator (show "Related Gerrit Patches")) which is an extremely useful feature, but it does not show the WIP status of patches. Like negative reviews etc., WIP status is important for knowing whether a patch requires action; it would be nice if it resulted in a different icon.
Description
Description
Related Objects
Related Objects
Event Timeline
Comment Actions
I believe the code integrating Gerrit changes inside Phabricator to be https://gitlab.wikimedia.org/repos/phabricator/extensions/-/blob/wmf/stable/src/customfields/GerritPatchesCustomField.php.
The code hits the Query Change API which yields a list of ChangeInfo objects.
When the patch is a work in progress, an extra field is set work_in_progress, else the field is absent.
So I guess the condition can be array_key_exists( 'work_in_progress', $change ) and maybe append the text WIP to the icon.
Comment Actions
aklapper opened https://gitlab.wikimedia.org/repos/phabricator/extensions/-/merge_requests/10
Indicate WIP status of Gerrit patches
Comment Actions
aklapper closed https://gitlab.wikimedia.org/repos/phabricator/extensions/-/merge_requests/10
Indicate WIP status of Gerrit patches
Comment Actions
Note to myself: The GitLab UI when deleting personal projects is not particularly clear when it displays "0 patches, 0 issues, 0 etc" etc. I did not realize that this message does not cover open merge requests for the main branch, so I need to re-do this patch...
Comment Actions
aklapper opened https://gitlab.wikimedia.org/repos/phabricator/extensions/-/merge_requests/21
Indicate WIP status of Gerrit patches
Comment Actions
brennen merged https://gitlab.wikimedia.org/repos/phabricator/extensions/-/merge_requests/21
Indicate WIP status of Gerrit patches