Indicate WIP status of patches on Phabricator patch list
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tgr
	Dec 14 2022, 8:27 PM

Description

Phabricator lists the Gerrit patches associated with a task, with icons indicating status such as comments or negative reviews (T229934: Enable semantic relationship between code review changesets and maniphest tasks in phabricator (show "Related Gerrit Patches")) which is an extremely useful feature, but it does not show the WIP status of patches. Like negative reviews etc., WIP status is important for knowing whether a patch requires action; it would be nice if it resulted in a different icon.

Details

	Title	Reference	Author	Source Branch	Dest Branch
	Indicate WIP status of Gerrit patches	repos/phabricator/extensions!21	aklapper	T325239	wmf/stable
	Indicate WIP status of Gerrit patches	repos/phabricator/extensions!10	aklapper	aklapper-wmf/stable-patch-83645	wmf/stable

Customize query in GitLab

Related Objects

Mentioned Here: T229934: Enable semantic relationship between code review changesets and maniphest tasks in phabricator (show "Related Gerrit Patches")

Event Timeline

Tgr created this task.Dec 14 2022, 8:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2022, 8:27 PM

kostajh awarded a token.Dec 19 2022, 1:40 PM

kostajh subscribed.

Aklapper edited projects, added Wikimedia-Phabricator-Extensions; removed GerritBot.Jun 8 2023, 1:29 PM

Aklapper moved this task from To Triage to Needs code (in Phab or bot) on the Phabricator board.

I believe the code integrating Gerrit changes inside Phabricator to be https://gitlab.wikimedia.org/repos/phabricator/extensions/-/blob/wmf/stable/src/customfields/GerritPatchesCustomField.php.

The code hits the Query Change API which yields a list of ChangeInfo objects.

When the patch is a work in progress, an extra field is set work_in_progress, else the field is absent.

So I guess the condition can be array_key_exists( 'work_in_progress', $change ) and maybe append the text WIP to the icon.

aklapper opened https://gitlab.wikimedia.org/repos/phabricator/extensions/-/merge_requests/10

Indicate WIP status of Gerrit patches

CodeReviewBot added a project: Patch-For-Review.Jun 8 2023, 2:36 PM

Aklapper claimed this task.Jun 8 2023, 2:41 PM

Aklapper triaged this task as Low priority.

Aklapper added a project: Release-Engineering-Team (They Live 🕶️🧟).

jeena moved this task from Backlog to Done on the Release-Engineering-Team (They Live 🕶️🧟) board.Jun 12 2023, 9:09 PM

jeena moved this task from Done to Waiting for review on the Release-Engineering-Team (They Live 🕶️🧟) board.

thcipriani edited projects, added Release-Engineering-Team (Escape Goats🐐); removed Release-Engineering-Team (They Live 🕶️🧟).Jul 26 2023, 2:52 PM

thcipriani moved this task from Backlog to Waiting for review on the Release-Engineering-Team (Escape Goats🐐) board.Jul 26 2023, 3:21 PM

aklapper closed https://gitlab.wikimedia.org/repos/phabricator/extensions/-/merge_requests/10

Indicate WIP status of Gerrit patches

Maintenance_bot removed a project: Patch-For-Review.Sep 16 2023, 12:10 PM

Note to myself: The GitLab UI when deleting personal projects is not particularly clear when it displays "0 patches, 0 issues, 0 etc" etc. I did not realize that this message does not cover open merge requests for the main branch, so I need to re-do this patch...

aklapper opened https://gitlab.wikimedia.org/repos/phabricator/extensions/-/merge_requests/21

Indicate WIP status of Gerrit patches

hashar unsubscribed.Sep 20 2023, 8:14 AM

brennen merged https://gitlab.wikimedia.org/repos/phabricator/extensions/-/merge_requests/21

Indicate WIP status of Gerrit patches

Maintenance_bot removed a project: Patch-For-Review.Oct 16 2023, 9:30 PM