Page MenuHomePhabricator

Remove uses of 'rawTitle'/'origTitle'
Closed, ResolvedPublic

Description

Uses of 'rawTitle'/'origTitle' in VE source code indicate places where we are very inflexible about how we treat links to other pages in the HTML. They make it difficult to swap the URL libraries (T325249) and handle different URL patterns (T270219). We should refactor to remove them.

Event Timeline

Change 870691 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@master] Ignore 'origTitle' in tests

https://gerrit.wikimedia.org/r/870691

Change 870692 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Fix encoding to roundtrip links without 'rawTitle'/'origTitle'

https://gerrit.wikimedia.org/r/870692

Change 870693 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Cite@master] Remove 'origTitle' in tests

https://gerrit.wikimedia.org/r/870693

Change 870691 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Ignore 'origTitle' in tests

https://gerrit.wikimedia.org/r/870691

Change 870902 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (cb9c5fadc)

https://gerrit.wikimedia.org/r/870902

Change 870902 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (cb9c5fadc)

https://gerrit.wikimedia.org/r/870902

Change 870692 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix encoding to roundtrip links without 'rawTitle'/'origTitle'

https://gerrit.wikimedia.org/r/870692

Change 870693 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Remove 'origTitle' in tests

https://gerrit.wikimedia.org/r/870693

matmarex edited projects, added Editing QA; removed Patch-For-Review.

QA instructions: Sorry, this is going to be vague, but try editing pages with internal links on them ([[...]] in wikitext) that contain special characters, or weird percent-encoding, and verify that they do not get changed while editing other content on the same page (no dirty diffs) and that they display correctly (like in view mode) and are editable.

I noted this as a risky change, to help route bug reports to us if there's something wrong: T325581#8510914

matmarex edited projects, added Skipped QA; removed Editing QA.

This has been live for a while with no issues reported, I think we can assume it's fine.