Page MenuHomePhabricator
Create Task
Maniphest T325249

Replace use of mw.Uri in VE with native URL API
Closed, ResolvedPublic
Actions

Description

We should replace use of mw.Uri in VE with native URL API. The mw.Uri library doesn't handle URLs exactly like browsers and web servers do, which over the years has caused many bugs (T325566, T324976, T286009, T268064, T270331, T106244, T66884, and more).

Previously done for DiscussionTools: T305010

Details

SubjectRepoBranchLines +/-
Rewrite mw.libs.ve.getTargetDataFromHref with URL APImediawiki/extensions/VisualEditormaster+181 -151
Re-apply "Remove references to mediawiki.Uri"mediawiki/extensions/VisualEditormaster+1 -11
Re-apply "Rewrite mw.libs.ve.getTargetDataFromHref with URL API"mediawiki/extensions/VisualEditormaster+181 -151
Remove references to mediawiki.Urimediawiki/extensions/VisualEditormaster+1 -11
Replace mediawiki.Uri with native URL (ArticleTarget)mediawiki/extensions/VisualEditormaster+180 -183
Allow using native URL (or polyfill)mediawiki/extensions/VisualEditormaster+10 -1
Replace mediawiki.Uri with native URL (easy cases)mediawiki/extensions/VisualEditormaster+28 -37
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Dec 14 2022, 10:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2022, 10:11 PM
gerritbot added a comment.Dec 14 2022, 10:58 PM

Change 867270 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] [WIP] Replace mediawiki.Uri with native URL (or polyfill)

https://gerrit.wikimedia.org/r/867270

gerritbot added a project: Patch-For-Review.Dec 14 2022, 10:58 PM

Change 868191 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Rewrite mw.libs.ve.getTargetDataFromHref with URL API

https://gerrit.wikimedia.org/r/868191

Krinkle awarded a token.Dec 15 2022, 8:04 AM
ppelberg added a project: Editing-team (Kanban Board).Dec 15 2022, 4:49 PM
ppelberg moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
ppelberg moved this task from To Triage to Triaged on the VisualEditor board.
matmarex moved this task from Code Review to Doing on the Editing-team (Kanban Board) board.Dec 15 2022, 7:38 PM
gerritbot added a comment.Dec 17 2022, 4:05 PM

Change 868783 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Allow using native URL (or polyfill)

https://gerrit.wikimedia.org/r/868783

gerritbot added a comment.Dec 17 2022, 4:05 PM

Change 868784 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Replace mediawiki.Uri with native URL (ArticleTarget)

https://gerrit.wikimedia.org/r/868784

gerritbot added a comment.Dec 17 2022, 4:05 PM

Change 868785 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Remove references to mediawiki.Uri

https://gerrit.wikimedia.org/r/868785

matmarex moved this task from Doing to Code Review on the Editing-team (Kanban Board) board.Dec 17 2022, 4:08 PM
matmarex mentioned this in T325766: Remove uses of 'rawTitle'/'origTitle'.Dec 21 2022, 5:58 PM
matmarex added a subtask: T325766: Remove uses of 'rawTitle'/'origTitle'.
matmarex updated the task description. (Show Details)Dec 22 2022, 6:02 PM
matmarex mentioned this in T325566: VisualEditor percent-encodes all single quote in red link target fragments, producing dirty diff.Dec 22 2022, 6:04 PM
matmarex added a parent task: T325566: VisualEditor percent-encodes all single quote in red link target fragments, producing dirty diff.
gerritbot added a comment.Jan 4 2023, 8:12 AM

Change 868783 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Allow using native URL (or polyfill)

https://gerrit.wikimedia.org/r/868783

gerritbot added a comment.Jan 4 2023, 8:12 AM

Change 867270 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Replace mediawiki.Uri with native URL (easy cases)

https://gerrit.wikimedia.org/r/867270

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 4 2023, 3:02 PM
gerritbot added a comment.Jan 10 2023, 5:45 PM

Change 868784 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Replace mediawiki.Uri with native URL (ArticleTarget)

https://gerrit.wikimedia.org/r/868784

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.19; 2023-01-16); removed MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 10 2023, 6:00 PM
matmarex moved this task from Code Review to Doing on the Editing-team (Kanban Board) board.Jan 10 2023, 6:11 PM
matmarex moved this task from Doing to Code Review on the Editing-team (Kanban Board) board.Jan 23 2023, 3:02 PM
gerritbot added a comment.Jan 23 2023, 4:09 PM

Change 868191 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Rewrite mw.libs.ve.getTargetDataFromHref with URL API

https://gerrit.wikimedia.org/r/868191

gerritbot added a comment.Jan 23 2023, 4:12 PM

Change 868785 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove references to mediawiki.Uri

https://gerrit.wikimedia.org/r/868785

Maintenance_bot removed a project: Patch-For-Review.Jan 23 2023, 4:31 PM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.20; 2023-01-23); removed MW-1.40-notes (1.40.0-wmf.19; 2023-01-16).Jan 23 2023, 5:00 PM
matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Jan 23 2023, 5:23 PM
matmarex added a project: Skipped QA.
matmarex claimed this task.Jan 23 2023, 5:26 PM
matmarex mentioned this in T327779: VisualEditor adds link= attribute to file transclusion if lang= parameter is set.Jan 24 2023, 1:42 PM
ppelberg closed this task as Resolved.Jan 26 2023, 4:42 AM
ppelberg closed subtask T325766: Remove uses of 'rawTitle'/'origTitle' as Resolved.
matmarex added a parent task: T327779: VisualEditor adds link= attribute to file transclusion if lang= parameter is set.Jan 26 2023, 10:44 AM
matmarex reopened this task as Open.Jan 30 2023, 2:51 PM
matmarex moved this task from Ready for Sign Off to Blocked / Needs More Work on the Editing-team (Kanban Board) board.
matmarex removed a project: Skipped QA.

The last 2 patches were reverted due to revealing issues in ContentTranslation: T328143.

matmarex added a subtask: T328143: Machine Translation is broken when content has a link.Jan 30 2023, 2:52 PM
gerritbot added a comment.Jan 30 2023, 2:58 PM

Change 884502 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Re-apply "Rewrite mw.libs.ve.getTargetDataFromHref with URL API"

https://gerrit.wikimedia.org/r/884502

gerritbot added a project: Patch-For-Review.Jan 30 2023, 2:58 PM

Change 884503 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Re-apply "Remove references to mediawiki.Uri"

https://gerrit.wikimedia.org/r/884503

matmarex closed subtask T328143: Machine Translation is broken when content has a link as Resolved.Feb 1 2023, 10:44 PM
gerritbot added a comment.Feb 2 2023, 9:22 AM

Change 884502 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Re-apply "Rewrite mw.libs.ve.getTargetDataFromHref with URL API"

https://gerrit.wikimedia.org/r/884502

gerritbot added a comment.Feb 2 2023, 9:23 AM

Change 884503 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Re-apply "Remove references to mediawiki.Uri"

https://gerrit.wikimedia.org/r/884503

Maintenance_bot removed a project: Patch-For-Review.Feb 2 2023, 9:31 AM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.22; 2023-02-06); removed MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Feb 2 2023, 10:00 AM
matmarex moved this task from Blocked / Needs More Work to Ready for Sign Off on the Editing-team (Kanban Board) board.Feb 2 2023, 4:39 PM
matmarex added a project: Skipped QA.
ppelberg closed this task as Resolved.Feb 6 2023, 5:36 PM
matmarex mentioned this in T365058: User mentions cause infinite loading. .May 16 2024, 10:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL