Page MenuHomePhabricator
Create Task
Maniphest T327779

VisualEditor adds link= attribute to file transclusion if lang= parameter is set
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The file transclusion of [[Datei:TUWien dwh.at Covid Intensity.svg|lang=de|mini|Simulationsmodell von [...]]] (Datei: is German namespace name for File:) gets appended with |verweis=Datei:TUWien_dwh.at_Covid_Intensity.svg%3Flang=de (verweis= is German l10n of link=)

What should have happened instead?:
no change in file transclusion

Other information (browser name/version, screenshots, etc.):
Similar changes, all affecting svg files with lang attribute:

Details

SubjectRepoBranchLines +/-
Re-apply "Rewrite mw.libs.ve.getTargetDataFromHref with URL API"mediawiki/extensions/VisualEditormaster+181 -151
Customize query in gerrit

Related Objects
Search...

Event Timeline

hgzh created this task.Jan 24 2023, 12:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 24 2023, 12:36 PM
XanonymusX subscribed.Jan 24 2023, 12:50 PM
Gelegenheits-Wikipedianer subscribed.Jan 24 2023, 1:12 PM

Additional info: This is not limited to SVG files, it also happens for PDFs when given a page=xx parameter. Example:

matmarex subscribed.Jan 24 2023, 1:42 PM

Thanks for the report. This may be a regression from the recent work on T325766 or T324352.

It looks like it's already fixed in the latest version, following the work on T325249. The fix should be deployed to Wikimedia wikis later this week.

Sorry about that :(

matmarex added a project: Editing-team (Kanban Board).Jan 24 2023, 1:42 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.
matmarex added a project: Editing QA.
hgzh added a comment.Jan 24 2023, 2:20 PM

Thanks for having a look on this, we will check on thursday if there's still a problem.

matmarex added a subtask: T325249: Replace use of mw.Uri in VE with native URL API.Jan 26 2023, 10:44 AM
Gelegenheits-Wikipedianer added a comment.Jan 27 2023, 9:55 AM

Looks like the fix/update worked, I currently cannot reproduce the bug on de german Wikipedia.

EAkinloose edited projects, added Verified; removed Editing QA.Jan 30 2023, 7:32 AM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
matmarex mentioned this in T328143: Machine Translation is broken when content has a link.Jan 30 2023, 1:51 PM
matmarex reopened subtask T325249: Replace use of mw.Uri in VE with native URL API as Open.Jan 30 2023, 2:51 PM
matmarex removed a project: Verified.
matmarex moved this task from Ready for Sign Off to Blocked / Needs More Work on the Editing-team (Kanban Board) board.

The fix was reverted due to revealing issues in ContentTranslation: T328143. Hopefully we'll find a better solution for that and reinstate this soon.

matmarex claimed this task.Jan 30 2023, 2:54 PM
gerritbot added a comment.Jan 30 2023, 2:58 PM

Change 884502 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Re-apply "Rewrite mw.libs.ve.getTargetDataFromHref with URL API"

https://gerrit.wikimedia.org/r/884502

gerritbot added a project: Patch-For-Review.Jan 30 2023, 2:58 PM
gerritbot added a comment.Feb 2 2023, 9:22 AM

Change 884502 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Re-apply "Rewrite mw.libs.ve.getTargetDataFromHref with URL API"

https://gerrit.wikimedia.org/r/884502

Maintenance_bot removed a project: Patch-For-Review.Feb 2 2023, 9:30 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 2 2023, 10:00 AM
matmarex moved this task from Blocked / Needs More Work to QA on the Editing-team (Kanban Board) board.Feb 2 2023, 4:39 PM
matmarex added a project: Editing QA.
matmarex added a comment.Feb 2 2023, 4:44 PM

The fix will be deployed again next week, on the usual schedule. Sorry about that, it's impractical to backport due to dependencies on other software.

If you need help fixing the damage to articles afterwards, please say and I will do my best.

ppelberg closed subtask T325249: Replace use of mw.Uri in VE with native URL API as Resolved.Feb 6 2023, 5:36 PM
EAkinloose edited projects, added Verified; removed Editing QA.Feb 12 2023, 9:22 PM
EAkinloose subscribed.

Screenshot 2023-02-12 at 22.21.46.png (748×1 px, 178 KB)

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Feb 12 2023, 9:23 PM
ppelberg closed this task as Resolved.Feb 13 2023, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL