Maniphest T326007

Default View: ZObjectKeyValue tests
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ddwaal
	Dec 29 2022, 3:20 PM

Tags

Referenced Files

None

Subscribers

Description

Description

The default ZObjectKeyValue Component should have full unit test coverage.

Devices and Design (URLs or screenshots)

Desktop: ...
Small screens/mobile: ...

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Front-end_Task/Bug_Completion_Checklist

Details

	Subject	Repo	Branch	Lines +/-
	add additional ZObjectKeyValue test	mediawiki/extensions/WikiLambda	master	+28 -5
	Add tests for ZObjectKeyValue.	mediawiki/extensions/WikiLambda	master	+477 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		gengh	T324242 DefaultView: Cleanup code from old ZObjectEditor and ZObjectView
		Resolved		gengh	T324241 DefaultView: Switch view and edit pages to use DefaultView instead of ZObjectView and ZObjectEditor
		Resolved		• JKieserman	T326007 Default View: ZObjectKeyValue tests

Event Timeline

Ddwaal renamed this task from Default ZObjectKeyValue Component: Add unit tests to Default View: ZObjectKeyValue Component tests.Dec 29 2022, 3:20 PM

Ddwaal renamed this task from Default View: ZObjectKeyValue Component tests to Default View: ZObjectKeyValue tests.

Ddwaal created this task.

Ddwaal moved this task from To Triage to Phase θ – Throttling on the Abstract Wikipedia team board.

Ddwaal edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.

Ddwaal moved this task from Incoming to Ready: G5. Fallback view on the Abstract Wikipedia team (Phase θ – Throttling) board.

Ddwaal claimed this task.Dec 29 2022, 3:22 PM

Change 872977 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Add tests for ZObjectKeyValue

https://gerrit.wikimedia.org/r/872977

gerritbot added a project: Patch-For-Review.Dec 29 2022, 3:29 PM

Change 872977 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add tests for ZObjectKeyValue.

https://gerrit.wikimedia.org/r/872977

Maintenance_bot removed a project: Patch-For-Review.Jan 3 2023, 4:30 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 4 2023, 2:02 PM

There are two test stubs that need completing. Notes in patch description of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/872977/

DVrandecic added a parent task: T324241: DefaultView: Switch view and edit pages to use DefaultView instead of ZObjectView and ZObjectEditor.Jan 10 2023, 10:17 PM

Change 884948 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/WikiLambda@master] add additional ZObjectKeyValue tests

https://gerrit.wikimedia.org/r/884948

gerritbot added a project: Patch-For-Review.Jan 30 2023, 4:30 PM

Change 884948 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] add additional ZObjectKeyValue test

https://gerrit.wikimedia.org/r/884948

Jdforrester-WMF moved this task from Ready: G5. Fallback view to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Feb 3 2023, 2:38 PM

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.22; 2023-02-06); removed MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Feb 3 2023, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 3 2023, 3:30 PM

DVrandecic closed this task as Resolved.Feb 7 2023, 8:44 PM