Page MenuHomePhabricator
Create Task
Maniphest T324242

DefaultView: Cleanup code from old ZObjectEditor and ZObjectView
Closed, ResolvedPublic
Actions

Description

Description

  1. Development of the DefaultView: T324217
  2. Switch fallback pages to DefaultView instead of ZObjectView and ZObjectEditor: T324241

Once the development of the DefaultView is finished and rerouted, we will need to clean up unused components, views and state methods.

  • Remove the unused views
  • Remove the unused components
  • Remove unused state management getters/actions/mutations from zobject.js
  • Remove tests for all the above

Completion checklist

Details

SubjectRepoBranchLines +/-
Remove unused components from old UImediawiki/extensions/WikiLambdamaster+0 -7 K
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedgenghT324242 DefaultView: Cleanup code from old ZObjectEditor and ZObjectView
 ResolvedgenghT324241 DefaultView: Switch view and edit pages to use DefaultView instead of ZObjectView and ZObjectEditor
 ResolvedJdforrester-WMFT324217 DefaultView: Create the minimum necessary components to have a fully functioning DefaultView
 ResolvedgenghT321784 Default component: Implement POC for default view/component structure
 Resolved• JKiesermanT324251 DefaultView: Create ZTypedList component
 ResolvedDVrandecicT310827 DefaultView: Design new Typed List component
 InvalidNoneT312259 [EDITING LISTS] list items can be reordered
 ResolvedDdwaalT312261 [EDITING LISTS] list items can be deleted
 InvalidNoneT312264 [EDITING LISTS] an item can be ordered by dragging
 ResolvedgenghT324246 DefaultView: Create ZMonolingualString custom component
 ResolvedgenghT324243 DefaultView: Create ZString atomic component
 ResolvedgenghT324244 DefaultView: Create ZReference atomic component
 ResolvedDVrandecicT324249 DefaultView: Create ZObjectType structural component
 ResolvedAAlhazwani-WMFT324248 DefaultView: Decide and add codex icons for the different type selection options in the dropdown field
 ResolvedAAlhazwani-WMFT306442 Design the fallback view experience for non-function ZObjects
 ResolvedgenghT323013 Default component: nested logic and visual style
 Resolved• JKiesermanT326738 DefaultView: Create ZCode component
 ResolvedgenghT327421 DefaultView: Create ZImplementation View and Component
 Resolved• JKiesermanT326007 Default View: ZObjectKeyValue tests
 ResolvedgenghT327918 DefaultView: Create LabelBox for the DefaultView
 ResolvedgenghT336997 DefaultView: Fix integration tests to use DefaultView instead of ZObjectEditor/Viewer

Event Timeline

gengh created this task.Dec 1 2022, 8:04 PM
gengh changed the task status from Open to Stalled.Dec 1 2022, 8:43 PM
gengh moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.
gengh edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
gengh moved this task from Incoming to Ready: G5. Fallback view on the Abstract Wikipedia team (Phase θ – Throttling) board.
DVrandecic added a subtask: T324241: DefaultView: Switch view and edit pages to use DefaultView instead of ZObjectView and ZObjectEditor.Dec 8 2022, 10:08 PM
DVrandecic added a subtask: T324249: DefaultView: Create ZObjectType structural component.Dec 8 2022, 10:32 PM
• RWambua-WMF added a parent task: T324802: Phase θ Goal 5: Fallback view.Dec 8 2022, 11:51 PM
• RWambua-WMF removed a subtask: T324249: DefaultView: Create ZObjectType structural component.Dec 8 2022, 11:53 PM
Jdforrester-WMF added a project: Abstract Wikipedia Fix-It tasks.May 30 2023, 10:30 PM
Jdforrester-WMF changed the task status from Stalled to In Progress.Jun 1 2023, 2:13 PM
Jdforrester-WMF triaged this task as High priority.
gengh claimed this task.Jun 2 2023, 8:46 AM
gengh closed subtask T324241: DefaultView: Switch view and edit pages to use DefaultView instead of ZObjectView and ZObjectEditor as Resolved.Jun 2 2023, 9:45 AM
gengh added subtasks: T329107: Vue store cleanup: Remove unused store methods, T329106: Vue store cleanup: Replace all the old store access methods with the new simplified ones.
gengh added a project: Epic.
gengh reopened subtask T324241: DefaultView: Switch view and edit pages to use DefaultView instead of ZObjectView and ZObjectEditor as Open.Jun 2 2023, 9:48 AM
gerritbot added a comment.Jun 2 2023, 7:10 PM

Change 926432 had a related patch set uploaded (by Jforrester; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Remove unused components from old UI

https://gerrit.wikimedia.org/r/926432

gerritbot added a project: Patch-For-Review.Jun 2 2023, 7:10 PM
gerritbot added a comment.Jun 2 2023, 7:13 PM

Change 926432 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Remove unused components from old UI

https://gerrit.wikimedia.org/r/926432

Jdforrester-WMF closed subtask T324241: DefaultView: Switch view and edit pages to use DefaultView instead of ZObjectView and ZObjectEditor as Resolved.Jun 2 2023, 7:16 PM
Jdforrester-WMF updated the task description. (Show Details)
Maintenance_bot removed a project: Patch-For-Review.Jun 2 2023, 7:30 PM
Jdforrester-WMF added a subtask: T336997: DefaultView: Fix integration tests to use DefaultView instead of ZObjectEditor/Viewer.Jun 14 2023, 12:40 PM
Jdforrester-WMF moved this task from Phase θ – Throttling to Phase λ – Launch on the Abstract Wikipedia team board.Jun 16 2023, 8:47 AM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase λ – Launch); removed Abstract Wikipedia team (Phase θ – Throttling).
Jdforrester-WMF moved this task from Incoming to In progress on the Abstract Wikipedia team (Phase λ – Launch) board.Jun 16 2023, 8:54 AM
Jdforrester-WMF removed a subtask: T329106: Vue store cleanup: Replace all the old store access methods with the new simplified ones.Jun 20 2023, 2:58 PM
Jdforrester-WMF removed a subtask: T329107: Vue store cleanup: Remove unused store methods.
Jdforrester-WMF removed gengh as the assignee of this task.Jul 24 2023, 8:54 PM
Jdforrester-WMF moved this task from In progress to Engineering tasks on the Abstract Wikipedia team (Phase λ – Launch) board.
gengh added a comment.Jul 26 2023, 8:46 AM

Whatever else is left for the cleanup should not be blocking launch or CUJ5; this is all fix-it week material

gengh claimed this task.Jul 26 2023, 8:46 AM
gengh updated the task description. (Show Details)
Jdforrester-WMF removed a parent task: T324802: Phase θ Goal 5: Fallback view.Jul 26 2023, 2:17 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase λ – Launch).
Jdforrester-WMF subscribed.
In T324242#9043558, @gengh wrote:

Whatever else is left for the cleanup should not be blocking launch or CUJ5; this is all fix-it week material

Done.

DVrandecic closed subtask T336997: DefaultView: Fix integration tests to use DefaultView instead of ZObjectEditor/Viewer as Resolved.Jul 27 2023, 2:36 AM
Jdforrester-WMF closed this task as Resolved.Jul 27 2023, 4:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL