Page MenuHomePhabricator

DefaultView: Create LabelBox for the DefaultView
Closed, ResolvedPublic

Assigned To
Authored By
gengh
Jan 25 2023, 2:55 PM
Referenced Files
F36951587: image.png
Apr 14 2023, 12:44 PM
F36819625: image.png
Feb 10 2023, 5:11 PM
F36819623: image.png
Feb 10 2023, 5:11 PM
F36754450: image.png
Feb 6 2023, 12:25 PM
F36754447: image.png
Feb 6 2023, 12:25 PM
F36754444: image.png
Feb 6 2023, 12:25 PM
F36571999: image.png
Feb 1 2023, 1:02 PM
F36572002: image.png
Feb 1 2023, 1:02 PM

Description

Description

In the soon-to-be-deprecated ZObjectEditor, the tree of components is displayed starting from the key Z2K2/Persistent Object Value, and all the other "metadata" that corresponds to the persistent object is displayed in adjacent components.

Currently the default view renders the whole ZObject tree starting from the root

This task includes:

  • Design the new LabelBox component (or decide not to re-design) that will display the multilingual information of the object
  • Implement the new LabelBox component or adapt the existing one to work with the current DefaultView architecture
  • Insert the new LabelBox component in the DefaultView screen
  • Configure the DefaultView screen to show the content starting from Z2K2 instead of from the root

Desired behavior/Acceptance criteria

  • On the DefaultView screen:
  • Label and alias information of a persisted ZObject is shown in a structured table/component instead of being shown in the tree structure
  • The DefaultView tree structure starts from Z2K2 the same way that we did in ZObjectEditor, excluding the "metadata" from the persistent object keys

Devices and Design (URLs or screenshots)

Figma: https://www.figma.com/file/Lp739V7NSecfDQWMdQUaft/labelbox-T327918?node-id=87%3A7939&t=kuSTruoj8JcsZcXM-1


Completion checklist

Event Timeline

some early iterations! these are the identified aspects that we can be explored, and define for the label box. cc @DVrandecic @gengh

  1. layout: we need to define where the label box is displayed, based on the page layout, page viewport, and device (screenshot with grid overlay).

image.png (824×2 px, 199 KB)

  1. accordion: interaction, and style. especially useful on mobile web.

image.png (1×2 px, 210 KB)

  1. inline call to actions: "standard" codex buttons might be too prominent for this use case.

image.png (1×2 px, 207 KB)

  1. delete action: for deleting existing labels, or aliases.

image.png (762×2 px, 167 KB)

  1. add label/alias: we can (should?) build on top of the existing monolingual text component.

image.png (1×1 px, 188 KB)

here's a proposal ready to be reviewed @gengh! once we're happy, we can remove the Design tag. cc @DVrandecic

read labels and aliases

image.png (1×2 px, 295 KB)

edit or add labels and aliases

image.png (1×3 px, 492 KB)

desktop proposals are available too

image.png (1×2 px, 173 KB)

all designs are in figma too https://www.figma.com/file/Lp739V7NSecfDQWMdQUaft/labelbox-T327918?node-id=87%3A7939&t=YcbGc3sdMKrPbrpc-1

These are great! Left some minor questions about ease of implementation etc in figma.

AAlhazwani-WMF removed a project: Design.
AAlhazwani-WMF updated the task description. (Show Details)

task description updated with the most recent design proposal! attached some screenshots too for wider visibility.

image.png (1×2 px, 289 KB)

image.png (1×2 px, 402 KB)

after an internal consultation we decided to also add an object description to the label box, while we postponed the object documentation after launch. this an example of flow with the updated designs.

image.png (886×2 px, 289 KB)

gengh updated the task description. (Show Details)

Change 913259 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] [WIP] Add about widget for zobject multilingual information

https://gerrit.wikimedia.org/r/913259

Change 913259 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add About widget for zobject multilingual information

https://gerrit.wikimedia.org/r/913259

This is a brilliant implementation. Thank you!