[QA task] Testing UI workflows
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Apr 10 2023, 12:54 AM

Description

All issues refer to the following page: https://wikifunctions.beta.wmflabs.org/wiki/Z10064

Filed in T329982 (1) anon user doesn't have Edit source button available but there is View source tab which will allow anon users to see the page editing mode: https://wikifunctions.beta.wmflabs.org/w/index.php?title=Z10064&action=edit

Screen Shot 2023-04-09 at 5.31.19 PM.png (1×2 px, 220 KB)

The error: { "type": "error", "text": "ZError of type Z557" } is there a reference list of errors?
There is "Not wellformed" (additional work on phrasing may be needed here?) error for anon users - should anon users be informed of such errors since they would not be able to publish anyway?

Screen Shot 2023-04-09 at 5.42.04 PM.png (946×2 px, 194 KB)

N/A (2) A user clicks on "Show label box/Hide label box" - the Console error will be displayed: TypeError: Cannot read properties of undefined (reading 'length')

Screen Shot 2023-04-09 at 3.47.35 PM.png (1×2 px, 336 KB)

DONE (3) https://wikifunctions.beta.wmflabs.org/wiki/Z10064?success=true Multiplying 2*7=14 still produce failed Test results implementation with

Validator error summary:
[Z506/Argument type mismatch]
[Z518/Object type mismatch]

UI issues

N/A (4) There are duplicate links on a page

Screen Shot 2023-04-09 at 5.10.37 PM.png (1×2 px, 185 KB)

N/A (5) Extra white space

Screen Shot 2023-04-09 at 5.21.59 PM.png (606×2 px, 71 KB)

Screen Shot 2023-04-09 at 5.23.58 PM.png (1×1 px, 188 KB)

Details

	Subject	Repo	Branch	Lines +/-
	DefaultView: Hard code non-edit mode for logged-out users for now	mediawiki/extensions/WikiLambda	master	+2 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Etonkovidova	T334364 [QA task] Testing UI workflows
		Resolved		Jdforrester-WMF	T329982 Logged-out user doesn't have timely warnings in editing mode ("View source" button still opens editor)

Event Timeline

Etonkovidova created this task.Apr 10 2023, 12:54 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 10 2023, 12:54 AM

Maintenance_bot added a project: Abstract Wikipedia team.Apr 10 2023, 1:30 AM

Jdforrester-WMF moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Apr 10 2023, 3:51 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.

Jdforrester-WMF moved this task from Incoming to Ready: G5. Fallback view on the Abstract Wikipedia team (Phase θ – Throttling) board.Apr 10 2023, 3:53 PM

Etonkovidova updated the task description. (Show Details)Apr 10 2023, 9:18 PM

About errors:

There is a Reference page for errors: https://meta.wikimedia.org/wiki/Abstract_Wikipedia/Representation_of_errors
However, the user should not see "Error of type Z557" but the human-readable label of the error instead: "User does not have permission to edit"
This should be filed as a bug.

About publish dialog for Anon users:

They should not be able to attempt a save at all. I see three levels of issues that concern me:

Should not be able to go to the edit page, or
Should not see an active "Publish" button, and if they attempt it,
They should be given a Z557 (user cannot edit) even before being returned a Z502 (validation error)

Errors in the label box

This component will be deprecated in favor of this one https://phabricator.wikimedia.org/T327918, so I would not invest time on fixing this.

Duplicate labels

Same as above, this component will be deprecated soon.

Extra white space in the dialog

Seems like Amin filed a related task (style and spacing in the dialogs: https://phabricator.wikimedia.org/T334291)
Should we add this comment in that task instead?

Jdforrester-WMF added a subtask: T329982: Logged-out user doesn't have timely warnings in editing mode ("View source" button still opens editor).Apr 11 2023, 2:43 PM

Jdforrester-WMF moved this task from Phase θ – Throttling to Phase λ – Launch on the Abstract Wikipedia team board.Jun 16 2023, 9:03 AM

Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase λ – Launch); removed Abstract Wikipedia team (Phase θ – Throttling).

Jdforrester-WMF moved this task from Incoming to Engineering tasks on the Abstract Wikipedia team (Phase λ – Launch) board.Jun 16 2023, 9:40 AM

Change 933646 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] DefaultView: Hard code non-edit mode for logged-out users for now

https://gerrit.wikimedia.org/r/933646

gerritbot added a project: Patch-For-Review.Jun 27 2023, 8:52 PM

Closing this QA task as Resolved.

In T334364#8771452, @gengh wrote:

About errors:

There is a Reference page for errors: https://meta.wikimedia.org/wiki/Abstract_Wikipedia/Representation_of_errors
However, the user should not see "Error of type Z557" but the human-readable label of the error instead: "User does not have permission to edit"
This should be filed as a bug.

About publish dialog for Anon users:

They should not be able to attempt a save at all. I see three levels of issues that concern me:

Should not be able to go to the edit page, or

Should not see an active "Publish" button, and if they attempt it,

They should be given a Z557 (user cannot edit) even before being returned a Z502 (validation error)

This issue has been addressed in T329982.

Errors in the label box

This component will be deprecated in favor of this one https://phabricator.wikimedia.org/T327918, so I would not invest time on fixing this.

Duplicate labels

Same as above, this component will be deprecated soon.

Extra white space in the dialog

Seems like Amin filed a related task (style and spacing in the dialogs: https://phabricator.wikimedia.org/T334291)

Should we add this comment in that task instead?

Yes, all those issues are a part of deprecated UI design.

I've updated the task description to reflect that only one issue is still present.

Etonkovidova updated the task description. (Show Details)Jul 12 2023, 10:27 PM

Etonkovidova closed this task as Resolved.Jul 17 2023, 9:34 PM

Change 933646 abandoned by Jforrester:

[mediawiki/extensions/WikiLambda@master] DefaultView: Hard code non-edit mode for logged-out users for now

Reason:

https://gerrit.wikimedia.org/r/933646

Maintenance_bot removed a project: Patch-For-Review.Jul 25 2023, 8:10 PM

DVrandecic closed subtask T329982: Logged-out user doesn't have timely warnings in editing mode ("View source" button still opens editor) as Resolved.Jul 26 2023, 1:20 AM

	F36944424: Screen Shot 2023-04-09 at 5.23.58 PM.png
	Apr 10 2023, 12:54 AM

	F36944422: Screen Shot 2023-04-09 at 5.21.59 PM.png
	Apr 10 2023, 12:54 AM

	F36944419: Screen Shot 2023-04-09 at 5.10.37 PM.png
	Apr 10 2023, 12:54 AM

	F36944411: Screen Shot 2023-04-09 at 3.47.35 PM.png
	Apr 10 2023, 12:54 AM

	F36944431: Screen Shot 2023-04-09 at 5.42.04 PM.png
	Apr 10 2023, 12:54 AM

	F36944427: Screen Shot 2023-04-09 at 5.31.19 PM.png
	Apr 10 2023, 12:54 AM

[QA task] Testing UI workflows Closed, ResolvedPublicActions