Page MenuHomePhabricator

Padding top missing from dialogs
Closed, ResolvedPublic

Description

we're using the codex dialog, but the metadata header content is placed in the dialog body, which doesn't have a padding top.

CleanShot 2023-04-07 at 17.24.52@2x.png (1×2 px, 457 KB)

the padding top is applied to the actual codex dialog header which is hidden, hence the missing padding top from the dialogs.

CleanShot 2023-04-07 at 17.26.19@2x.png (1×954 px, 218 KB)

Event Timeline

Change 908579 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/WikiLambda@master] add an upper padding to the dialog

https://gerrit.wikimedia.org/r/908579

Change 908579 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] PublishDialog: Add an upper padding to the dialog

https://gerrit.wikimedia.org/r/908579

DVrandecic removed JKieserman as the assignee of this task.
DVrandecic added a subscriber: JKieserman.

I wanted to close and check this, which is why I assigned Julia, since she wrote the patch, but to be honest, the current system on Wikifunctions seems to still look the same.

Has this been indeed fixed?

Screenshot of Wikifunctions, https://wikifunctions.beta.wmflabs.org/wiki/Z10268

Screenshot 2023-05-16 at 17.18.23.png (785×1 px, 166 KB)

DVrandecic claimed this task.

As per discussion, closing this one. Filed T336913 for the new one.