| • alexhollender_WMF | |
| Jan 5 2023, 2:40 PM |
| F36990390: Screenshot 2023-05-09 at 6.36.04 PM.png | |
| May 10 2023, 1:39 AM |
| F36990389: Screenshot 2023-05-09 at 6.36.22 PM.png | |
| May 10 2023, 1:39 AM |
| F36976291: Screenshot 2023-05-04 at 8.50.44 PM.png | |
| May 5 2023, 3:59 AM |
| F36976289: Screenshot 2023-05-04 at 8.50.31 PM.png | |
| May 5 2023, 3:59 AM |
| F35998111: Screen Shot 2023-01-05 at 10.36.22 AM.png | |
| Jan 5 2023, 2:40 PM |
Currently the full-width toggle button's background is transparent. This is noticeable when the button is partially overlapping the gray background at the edge of the screen (which I've made light red to make the issue easier to see).
The button should follow the standard button styling in Codex (link), with a background of #f8f9fa, and then #fff when hovered.
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T326323#8828726 |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T326323#8839391 |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Make limited width button consistent with button spec | mediawiki/skins/Vector | master | +21 -20 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | AnneT | T322077 Lower the maintenance costs of TypeaheadSearch in Vector | |||
| Resolved | None | T334881 Improve VectorComponentButton.php and Button.mustache to be generic | |||
| Resolved | None | T326323 Full-width toggle button should be opaque |
This might be fixed in the future through a different solution. cc @KieranMcCann - let us know if you have concerns with this one.
@ovasileva Yes I agree that it could be addressed by a different solution in the near future. If it was possible to do a quick fix then might be worthwhile but it is very subtle so I wouldn’t say it’s a huge priority.
Change 914380 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/Vector@master] Make limited width button consistent with button spec
Change 914380 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Make limited width button consistent with button spec
Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
✅ AC1: Full-width toggle button should be opaque
Status: ✅ PASS
Environment: testwiki, nawiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
✅ AC1: Full-width toggle button should be opaque
I darkened the background to make it more obvious.
