| Sneha | |
| Jan 5 2023, 6:42 PM |
| F36563110: Screenshot_20230130-170608_Chrome (1).jpg | |
| Jan 31 2023, 1:16 AM |
| F36563108: Screenshot_20230130-170535_Firefox (1).jpg | |
| Jan 31 2023, 1:16 AM |
| F36563103: 899A49C1-1C85-4951-88E9-78C9E01500FF.png | |
| Jan 31 2023, 1:16 AM |
| F36563101: Screen Shot 2023-01-30 at 5.00.10 PM.png | |
| Jan 31 2023, 1:16 AM |
| F36563097: Screen Shot 2023-01-30 at 4.54.12 PM.png | |
| Jan 31 2023, 1:16 AM |
| F36422006: image.png | |
| Jan 23 2023, 9:31 AM |
| F36158018: image.png | |
| Jan 12 2023, 11:58 AM |
| F36002765: mobile preview bug.png | |
| Jan 5 2023, 6:42 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
Portrait images are shown in landscape format.
What should have happened instead?:
Each image should maintain its aspect ratio. See mock here. Image will only be cropped when its larger than the visiible space.
Software version (skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Portrait images are shown as landscape in commons widgets for mobile | mediawiki/extensions/SearchVue | master | +32 -37 |
This ticket will be completed by: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SearchVue/+/869300
@SimoneThisDot - I'm checking on beta and the search previews still display images in landscape mode. For example - &quickView=Cat
hei Elena,
I have checked on Beta and I cannot reproduce the issue:
This is what I see from the link you pasted above (link):
if you give me the link of some of the images that are not working, I can check it out for you
hei Elena,
I have checked on Beta and I cannot reproduce the issue:
This is what I see from the link you pasted above (link):
if you give me the link of some of the images that are not working, I can check it out for you
Re-checked - no issues found; I guess I was checking when the fix was not fully merged.
hei Elena,
I have checked on Beta and I cannot reproduce the issue:
This is what I see from the link you pasted above (link):
if you give me the link of some of the images that are not working, I can check it out for you
The link will display the article cards differently depending on a browser.
| FF 109 | Chrome 109 |
|---|---|
The Responsive mode is displayed; the article card is stretched  | Devtools mobile view needs to be enabled; the card is not stretched  |
Testing on real devices
| iPhone 11 - Safari and Chrome | Samsung Galaxy S8 - Firefox | Samsung Galaxy S8 Firefox - Chrome CORRECT |
|---|---|---|
 |  |  |
@Etonkovidova @matthiasmullie is this a duplicate of T328095? If not, please move back to Doing so this can be addressed.
After checking T328095: Mobile quick view - issues with displaying article card - the issue is still present. I'll do more checking in production.
Change 885739 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):
[mediawiki/extensions/SearchVue@master] Portrait images are shown as landscape in commons widgets for mobile
I have investigated this further and actual development was required. I have completed the following (now in review):
The above has been replicated for:
Change 885739 merged by jenkins-bot:
[mediawiki/extensions/SearchVue@master] Portrait images are shown as landscape in commons widgets for mobile
