Page MenuHomePhabricator
Create Task
Maniphest T326957

[M] Remove configuration setting that turns off/on mobile Search Preview
Closed, ResolvedPublic
Actions

Description

In T320666: [M] Ensure that QuickView mobile functionality isn't released until Milestone 3/mobile MVP is complete, we put mobile Search Preview functionality behind a config variable so that when we released desktop functionality, we were able to hide mobile functionality until it was tested and the MVP was ready. Once mobile is released, we should remove this config.

Acceptance Criteria

  • configuration setting that turns mobile Search Preview on/off is removed in all wikis where SearchVue is available
  • mobile functionality cannot be turned on/off on those wikis

Details

SubjectRepoBranchLines +/-
Remove mobile conditionalsmediawiki/extensions/SearchVuemaster+4 -38
Customize query in gerrit

Related Objects
Search...

Event Timeline

CBogen created this task.Jan 13 2023, 2:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 13 2023, 2:18 PM
AUgolnikova-WMF moved this task from Triage to Current Work on the Structured-Data-Backlog board.Jan 16 2023, 5:47 PM
AUgolnikova-WMF edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.Jan 17 2023, 2:19 PM
CBogen renamed this task from Remove configuration setting that turns off/on mobile Search Preview to [M] Remove configuration setting that turns off/on mobile Search Preview.Jan 25 2023, 5:36 PM
CBogen moved this task from Ready for Estimation to Blocked on the Structured-Data-Backlog (Current Work) board.Jan 25 2023, 6:02 PM

Blocked until mobile search preview is released

CBogen mentioned this in T328136: Switch mobile Search Preview config to on.Jan 27 2023, 2:54 PM
gerritbot added a comment.Jan 31 2023, 10:42 AM

Change 885290 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/SearchVue@master] Remove mobile conditionals

https://gerrit.wikimedia.org/r/885290

gerritbot added a project: Patch-For-Review.Jan 31 2023, 10:42 AM
matthiasmullie claimed this task.Jan 31 2023, 11:26 AM
gerritbot added a comment.Feb 1 2023, 11:27 AM

Change 885290 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Remove mobile conditionals

https://gerrit.wikimedia.org/r/885290

matthiasmullie mentioned this in rESVU488bbde82fa1: Remove mobile conditionals.Feb 1 2023, 11:28 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 1 2023, 11:30 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 1 2023, 12:00 PM
SimoneThisDot moved this task from Blocked to Needs QA on the Structured-Data-Backlog (Current Work) board.Feb 2 2023, 12:50 PM
CBogen added a parent task: T306341: [EPIC] Quickview/Search Preview panel on the special:search page.Feb 8 2023, 8:23 PM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Feb 8 2023, 11:44 PM
Etonkovidova closed this task as Resolved.Feb 15 2023, 9:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL