Signature containing only a contributions link not recognized by DiscussionTools
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Tacsipacsi
	Jan 15 2023, 10:46 AM

Description

Steps to reproduce

Open https://hu.wikiquote.org/w/index.php?title=Vita:Magyar_nyelv%C5%B1_palindromok_list%C3%A1ja&oldid=55057&dtenable=1&dtdebug=1.

Actual result

The debug mode highlights only one comment (mine). I had to write that comment using the legacy full-page editor, as there was no reply button.

Expected result

The debug mode highlights two comments (one from the anon, one from me). I could write my comment using the Reply Tool.

Other information

When I modify the wikitext to include a link in the anon’s signature to their talk page, the preview shows that two comments are recognized. When I conversely modify my signature to include only a link to my contribs (and neither to my user page nor to my talk page), the preview shows that there are no comments recognized. So it looks like, contrary to the signature requirements, a contribs page link isn’t enough for DiscussionTools to recognize the comment.

Details

	Subject	Repo	Branch	Lines +/-
	LanguageData: Use special page alias with spaces	mediawiki/extensions/DiscussionTools	master	+171 -15

Customize query in gerrit

Event Timeline

Tacsipacsi created this task.Jan 15 2023, 10:46 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2023, 10:46 AM

It does work elsewhere with just the contributions link.

Having not dug into this properly yet, my gut suspicion would be that it's because huwiki's URL for the contributions page contains non-ascii characters and we might be comparing them while they're still URLencoded. (i.e. Szerkesztő_közreműködései compared to Szerkeszt%C5%91_k%C3%B6zrem%C5%B1k%C3%B6d%C3%A9sei)

I would say it some underscore vs. space issue. Aliases are stored with underscores, the compare against parts of Title::getText would be with spaces.

Relevant code: https://codesearch.wmcloud.org/things/?q=specialContributionsName&repos=Extension:DiscussionTools

Patches welcome. Otherwise we'll get around to this later.

Umherirrender claimed this task.Jan 16 2023, 7:53 PM

Change 880534 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/DiscussionTools@master] LanguageData: Use special page alias with spaces

https://gerrit.wikimedia.org/r/880534

gerritbot added a project: Patch-For-Review.Jan 16 2023, 7:53 PM

matmarex added a project: Editing-team (Kanban Board).Jan 17 2023, 1:26 AM

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

Change 880534 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] LanguageData: Use special page alias with spaces

https://gerrit.wikimedia.org/r/880534

Thanks for the patch @Umherirrender!

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.19; 2023-01-16).Jan 17 2023, 2:00 AM

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Jan 17 2023, 7:37 PM

ppelberg awarded a token.

Thanks for the quick patch, it’s already fixed in production (on the page linked from the description)!

In T327021#8537965, @Tacsipacsi wrote:

Thanks for the quick patch, it’s already fixed in production (on the page linked from the description)!

Looks good!

Signature containing only a contributions link not recognized by DiscussionToolsClosed, ResolvedPublicBUG REPORTActions