Page MenuHomePhabricator
Create Task
Maniphest T327586

Multipage pager for PDF and DJVU should not use layout tables
Open, LowPublic
Actions

Description

The multipage navigation for PDF and DJVU implemented on File pages makes use of an HTML table to present the layout. The whole thing has basically been untouched ever since it was implemented (except by adding a JS paging)

  • Remove table layout
  • Deprecate old classnames
  • Remove old classnames from other software
    • wikimedia/eveskin
    • Extension:Theme
    • Skin:CologneBlue
    • Skin:GuMaxDD
    • Skin:Modern
    • Skin:MonoBook
    • Skin:Nostalgia
    • Skin:Truglass
    • Universal-Omega/Monaco
  • Remove old class names from core
  • Update the JS pager
  • Provide a basic option that work on mobile
  • Move outside of fullImageLink ?

Details

SubjectRepoBranchLines +/-
Filepage: multipage navigation reworkmediawiki/coremaster+213 -147
Customize query in gerrit

Event Timeline

TheDJ created this task.Jan 21 2023, 9:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 21 2023, 9:15 PM
TheDJ triaged this task as Low priority.Jan 21 2023, 9:16 PM
TheDJ updated the task description. (Show Details)
gerritbot added a comment.Jan 21 2023, 9:16 PM

Change 881940 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/core@master] Filepage: multipage navigation rework

https://gerrit.wikimedia.org/r/881940

gerritbot added a project: Patch-For-Review.Jan 21 2023, 9:16 PM
TheDJ updated the task description. (Show Details)Jan 21 2023, 9:17 PM
Izno edited projects, added MediaWiki-File-management; removed MediaWiki-General.Jan 22 2023, 1:43 AM
Maintenance_bot added a project: Commons.Jan 22 2023, 1:46 AM
Peachey88 removed a project: Commons.Jan 22 2023, 1:46 AM
gerritbot added a comment.Jan 22 2023, 4:42 PM

Change 881940 merged by jenkins-bot:

[mediawiki/core@master] Filepage: multipage navigation rework

https://gerrit.wikimedia.org/r/881940

matmarex subscribed.Jan 22 2023, 4:51 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Jan 22 2023, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 22 2023, 5:30 PM
Krinkle awarded a token.Jan 22 2023, 7:46 PM
Jdforrester-WMF awarded a token.Jan 24 2023, 11:00 PM
Jdforrester-WMF subscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL