ULS doesn't provide hreflang on its interwiki links
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Izno
	Jan 22 2023, 12:39 AM

Description

In the old sidebar for interwiki links, hreflang is provided for the targeted language.

ULS should do so also. It's honestly halfway to a bug that it does not given the point of the component.

Details

	Subject	Repo	Branch	Lines +/-
	Set hreflang attribute to the links	mediawiki/extensions/UniversalLanguageSelector	master	+2 -1

Customize query in gerrit

Event Timeline

Izno created this task.Jan 22 2023, 12:39 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2023, 12:39 AM

Maintenance_bot added a project: UniversalLanguageSelector.Jan 22 2023, 12:45 AM

Nemo_bis subscribed.Jan 22 2023, 4:27 PM

Nintendofan885 subscribed.Jan 22 2023, 5:42 PM

Change 882245 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/UniversalLanguageSelector@master] Set hreflang attribute to the links

https://gerrit.wikimedia.org/r/882245

gerritbot added a project: Patch-For-Review.Jan 23 2023, 4:56 AM

• santhosh claimed this task.Jan 23 2023, 4:56 AM

• santhosh added a project: Language-Team (Language-2023-January-March).

• santhosh moved this task from Quarter Backlog to In Review on the Language-Team (Language-2023-January-March) board.

Nikerabbit added a project: Unplanned-Sprint-Work.Jan 23 2023, 6:09 AM

Change 882245 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Set hreflang attribute to the links

https://gerrit.wikimedia.org/r/882245

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Jan 23 2023, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 23 2023, 4:30 PM

Jdlrobson moved this task from Incoming to Work with other teams on the Desktop Improvements (Vector 2022) board.Jan 23 2023, 7:33 PM

ovasileva subscribed.Jan 23 2023, 8:45 PM

ngkountas moved this task from In Review to Check after deployment on the Language-Team (Language-2023-January-March) board.Jan 27 2023, 2:20 PM

Nikerabbit moved this task from Check after deployment to Needs QA on the Language-Team (Language-2023-January-March) board.Feb 22 2023, 9:12 AM

@santhosh I am unclear how to test this, can you pls provide more details. Thank you

EChukwukere-WMF moved this task from Needs QA to Pending input for QA on the Language-Team (Language-2023-January-March) board.Feb 28 2023, 5:45 AM

@EChukwukere-WMF I think the only thing that needs to be checked is to inspect language link elements provided by the ULS and check that the a element has a (correct) hreflang attribute. (The ones I checked just now did.)

@jhsoby thanks alot for clarifying that!

Test status: QA PASS

the hreflang attributes are displayed in the a tags

Screenshot 2023-03-28 at 9.56.46 AM.png (967×1 px, 429 KB)

Screenshot 2023-03-28 at 9.49.31 AM.png (980×1 px, 531 KB)

Screenshot 2023-03-28 at 9.52.20 AM.png (990×1 px, 428 KB)

EChukwukere-WMF moved this task from Pending input for QA to Done on the Language-Team (Language-2023-January-March) board.Mar 28 2023, 3:00 PM

Izno closed this task as Resolved.Jan 6 2024, 11:52 PM

	F36931078: Screenshot 2023-03-28 at 9.52.20 AM.png
	Mar 28 2023, 2:59 PM

	F36931079: Screenshot 2023-03-28 at 9.49.31 AM.png
	Mar 28 2023, 2:59 PM

	F36931090: Screenshot 2023-03-28 at 9.56.46 AM.png
	Mar 28 2023, 2:59 PM

ULS doesn't provide hreflang on its interwiki linksClosed, ResolvedPublicActions

Description

Details

Event Timeline

ULS doesn't provide hreflang on its interwiki links
Closed, ResolvedPublic
Actions