Page MenuHomePhabricator
Create Task
Maniphest T328008

Make usage of Codex design tokens in Vue modules
Closed, ResolvedPublic
Actions

Description

Once T325237: Enable and document use of Codex design tokens within MediaWiki is completed it should be possible to start using design tokens from Codex as opposite of having our own copy of variables and many non-tokenized values. This should help dealing with font-size values and all properties that are relative to them (eg: margins, paddings, height of text blocks, etc.)

Affected modules:

  • ext.growthExperiments.Homepage.NewImpact
  • ext.growthExperiments.MentorDashboard
  • vue-components

Files importing vue-components/variables.less should replaced that import by resources/lib/codex-design-tokens/theme-wikimedia-ui.less and check all variables are present and the parsers does not fail.

Details

SubjectRepoBranchLines +/-
Use codex-design-tokens less variablesmediawiki/extensions/GrowthExperimentsmaster+96 -183
Customize query in gerrit

Related Objects
Search...

Event Timeline

Sgs created this task.Jan 26 2023, 11:06 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJan 26 2023, 11:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Sgs moved this task from Inbox to Triaged on the Growth-Team board.Jan 26 2023, 11:07 AM
Maintenance_bot added a project: GrowthExperiments-Mentorship.Jan 26 2023, 11:30 AM
gerritbot added a comment.Jan 29 2023, 9:27 PM

Change 884476 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Use codex-design-tokens less variables

https://gerrit.wikimedia.org/r/884476

gerritbot added a project: Patch-For-Review.Jan 29 2023, 9:27 PM
Sgs updated the task description. (Show Details)Jan 30 2023, 7:51 PM
Sgs claimed this task.Jan 30 2023, 7:56 PM
Sgs updated the task description. (Show Details)
Sgs moved this task from Triaged to Blocked on the Growth-Team board.
Sgs moved this task from Blocked to Sprint 0 (Growth Team) on the Growth-Team board.
Sgs edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
Sgs moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Maintenance_bot moved this task from New Tasks to In Progress on the GrowthExperiments-Mentorship board.Jan 30 2023, 8:15 PM
kostajh added a parent task: T323132: [Epic] Q3 FY 2022-23 Growth Maintenance Work.Feb 2 2023, 1:52 PM
Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 4 2023, 7:28 AM
gerritbot added a comment.Feb 4 2023, 7:47 AM

Change 884476 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Use codex-design-tokens less variables

https://gerrit.wikimedia.org/r/884476

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 4 2023, 8:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 4 2023, 8:30 AM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 17 2023, 12:31 AM
kostajh closed this task as Resolved.Mar 28 2023, 2:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL