Page MenuHomePhabricator

mw.notify messages cover the watch icon on Vector 2022, which is annoying when trying to temporarily watch a page
Closed, ResolvedPublic2 Estimated Story Points

Assigned To
Authored By
matmarex
Jan 26 2023, 6:02 PM
Referenced Files
F36866357: image.png
Feb 23 2023, 11:28 AM
F36866359: image.png
Feb 23 2023, 11:28 AM
F36512065: image.png
Jan 26 2023, 6:02 PM
F36512062: image.png
Jan 26 2023, 6:02 PM
F36512057: image.png
Jan 26 2023, 6:02 PM
F36512059: image.png
Jan 26 2023, 6:02 PM
Tokens
"Love" token, awarded by TheDJ.

Description

Scenario:

Usually to do that, you need to:

  1. Click the watch icon to unwatch the page
  2. Click the watch icon again to watch the page
  3. Select the expiry time from a dropdown that appears to watch it temporarily

On Vector 2022, step 2 here comes with an annoying interruption: the confirmation message from step 1 covers the watch icon, so you need to click it away first:

image.png (2×3 px, 1 MB)
image.png (2×3 px, 1 MB)

It seems that there is space above the navigation bar where the message could appear instead, and it wasn't intentional to make it appear here, but instead it just uses the same position on the screen as on legacy Vector:

image.png (2×3 px, 1 MB)

So, it could appear like this instead:

image.png (2×3 px, 1 MB)

Event Timeline

Change 887836 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/Vector@master] Split off mediawiki.notification styles for legacy Vector

https://gerrit.wikimedia.org/r/887836

Change 887836 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Split off mediawiki.notification styles for legacy Vector

https://gerrit.wikimedia.org/r/887836

So, it could appear like this instead:

image.png (2×3 px, 1 MB)

Note that the extra whitespace between the top menu and the content is going to be removed in T325219. The star is just barely visible still when unwatching:

image.png (192×563 px, 21 KB)
image.png (225×500 px, 24 KB)
matmarex claimed this task.

The task was removed from the sprint, so I assume no further work is planned. The current solution works well enough for me.