Fix missing label for collapsed ToC button
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	bwang
	Feb 1 2023, 6:15 PM

Description

Background

The label for the collapsed TOC dropdown (in both page tools and in the sticky header) is missing, this was previously working but probably regressed during PHP refactoring related to SkinComponents. This was discovered in T328480

AC

The collapsed TOC dropdown button has an accessible label using the vector-toc-collapsible-button-label locale

QA Results - Beta

AC	Status	Details
1	✅	T328584#8639525

QA Results - Prod

AC	Status	Details
1	✅	T328584#8645580

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add label text to TOC toggle buttons	mediawiki/skins/Vector	master	+6 -3

Customize query in gerrit

Related Objects

Mentioned In: T328575: Allow dropdown contents to be accessible for screen reader users even when dropdown is closed
T328480: Investigate accessibility of Vector 2022 ToC button on smaller screen sizes
Mentioned Here: T328480: Investigate accessibility of Vector 2022 ToC button on smaller screen sizes

Event Timeline

bwang created this task.Feb 1 2023, 6:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 1 2023, 6:15 PM

bwang added a project: Web-Team-Backlog-Archived (Web Team FY2022-23 Q3 Sprint 3).Feb 1 2023, 6:16 PM

bwang mentioned this in T328480: Investigate accessibility of Vector 2022 ToC button on smaller screen sizes.Feb 1 2023, 7:10 PM

Graham87 subscribed.Feb 1 2023, 10:12 PM

Chlod subscribed.Feb 1 2023, 11:08 PM

bwang renamed this task from Fix missing label for collapsed ToC to Fix missing label for collapsed ToC button.Feb 2 2023, 6:45 PM

LGoto triaged this task as High priority.Feb 2 2023, 6:47 PM

LGoto set the point value for this task to 2.

LGoto moved this task from Incoming to Ready for Development on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q3 Sprint 3) board.

Jdlrobson added a project: Regression.Feb 2 2023, 6:47 PM

bwang mentioned this in T328575: Allow dropdown contents to be accessible for screen reader users even when dropdown is closed.Feb 3 2023, 8:58 PM

Jdrewniak claimed this task.Feb 15 2023, 7:46 PM

Jdrewniak moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q3 Sprint 3) board.

Change 889631 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Add label text to ToC toggle button near page title

https://gerrit.wikimedia.org/r/889631

gerritbot added a project: Patch-For-Review.Feb 15 2023, 8:25 PM

Jdrewniak removed Jdrewniak as the assignee of this task.Feb 16 2023, 2:15 PM

Jdrewniak moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q3 Sprint 3) board.

Jdrewniak subscribed.

Change 889631 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Add label text to TOC toggle buttons

https://gerrit.wikimedia.org/r/889631

Maintenance_bot removed a project: Patch-For-Review.Feb 16 2023, 4:10 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.24; 2023-02-20).Feb 16 2023, 5:00 PM

bwang assigned this task to Edtadros.Feb 16 2023, 9:29 PM

bwang moved this task from Code Review to QA on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q3 Sprint 3) board.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: TOC Toggle should have an accessibility label.

Screen Recording 2023-02-22 at 5.37.39 PM.mov.gif (884×938 px, 335 KB)

Screen Recording 2023-02-22 at 5.40.17 PM.mov.gif (884×938 px, 385 KB)

Screen Recording 2023-02-22 at 5.41.40 PM.mov.gif (884×1 px, 447 KB)

@bwang, please confirm I'm verifying the correct thing here. I included the html in the screen grab for your reference.

Jdlrobson reassigned this task from bwang to Edtadros.Feb 23 2023, 5:36 PM

Edtadros moved this task from QA to QA in Production on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q3 Sprint 3) board.Feb 24 2023, 11:33 PM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: TOC Toggle should have an accessibility label.

Screen Recording 2023-02-24 at 3.50.17 PM.mov.gif (1×974 px, 402 KB)

Screen Recording 2023-02-24 at 3.47.19 PM.mov.gif (1×1 px, 487 KB)

Screen Recording 2023-02-24 at 3.45.54 PM.mov.gif (1×1 px, 579 KB)

Edtadros updated the task description. (Show Details)Feb 24 2023, 11:56 PM

ovasileva closed this task as Resolved.Feb 27 2023, 4:50 PM

	F36869934: Screen Recording 2023-02-24 at 3.45.54 PM.mov.gif
	Feb 24 2023, 11:54 PM

	F36869933: Screen Recording 2023-02-24 at 3.47.19 PM.mov.gif
	Feb 24 2023, 11:54 PM

	F36869932: Screen Recording 2023-02-24 at 3.50.17 PM.mov.gif
	Feb 24 2023, 11:54 PM

	F36865863: Screen Recording 2023-02-22 at 5.41.40 PM.mov.gif
	Feb 23 2023, 1:44 AM

	F36865862: Screen Recording 2023-02-22 at 5.40.17 PM.mov.gif
	Feb 23 2023, 1:44 AM

	F36865861: Screen Recording 2023-02-22 at 5.37.39 PM.mov.gif
	Feb 23 2023, 1:44 AM

Fix missing label for collapsed ToC buttonClosed, ResolvedPublic2 Estimated Story PointsActions

Description

Background

AC

QA Results - Beta

QA Results - Prod

Details

Related Objects

Event Timeline

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

Fix missing label for collapsed ToC button
Closed, ResolvedPublic2 Estimated Story Points
Actions