Page MenuHomePhabricator

[S] Mobile search Preview not shown for articles with existing desktop search preview
Closed, ResolvedPublic

Description

Steps to reproduce (not exact steps) :

  • go to Special:Search on pilot wikis (where the search preview is enabled) on mobile
  • perform a search - see below two examples when mobile preview search doesn't show anything while desktop preview will present much more information.

(1) ru: &quickView=Formula+Rossa

(2) id: &quickView=Rusalka
https://id.wikipedia.org/w/index.php?search=rusalka&title=Istimewa:Pencarian&profile=advanced&fulltext=1&ns0=1&quickView=Rusalka

(3) pt:&quickView=Distritos+do+Nepal

Acceptance Criteria

  • Search Preview should always show on mobile when enabled, if any of the "info content" cards exist (i.e. article image, wikidata description, sections)
  • The only time Search Preview should not show on mobile when enabled is if there is no content in any of the "info content" cards

Event Timeline

This is an expected feature (that we may need to discuss)

On Mobile the Search Preview is NOT shown if the Wikidata Description and Sections are missing..

The reason for it, is that showing this preview (with the absence of the above two section) will just show the main images and Commons images if available...

As I mentioned this was part of the mobile requirements, so happy to change it

This is an expected feature (that we may need to discuss)

On Mobile the Search Preview is NOT shown if the Wikidata Description and Sections are missing..

The reason for it, is that showing this preview (with the absence of the above two section) will just show the main images and Commons images if available...

As I mentioned this was part of the mobile requirements, so happy to change it

Thank you for the clarification! (@Sneha).

Hi @SimoneThisDot can you point to a ticket where this was specified as I do not recall. I think it is still worth showing the preview even if all we have is images.

The ticket itself was this on: https://phabricator.wikimedia.org/T321944

The ticket does not specify what the "content" refer too in this instance and we had a chat conversation about it, but we have never discussed the Image as content. If you think we should show a preview even if just the image is shown, then this ticket Ac should change to:

"Show the mobile preview if also if the only available resource is the preview".

I personally think that if we just have the preview, we should do a different layout (as it is kind of a glorified thumbnail) and not show the preview design with nothing around it, but it is a simple change for me, so I can do it.

Just to clarify, with the above change the following will take place:

  • If "image, description and sections are missing" - Do not show preview
  • If "image, description, sections are missing, but Commons is available" - The preview is still NOT shown (we discussed this that to be able to show it we need for the client to wait even longer as we have to do 2 requests and this is very uncommon for an article o have no info but commons)
  • if "anything between Image, description and sections" are available - Show the preview

Yeah with content I meant, everything we show in preview i.e. all the cards on mobile. I think the cards layout was done with these scenario in mind and so I do not think we need to come up with a new one. I think it is okay for preview to be glorified images. I also think it is okay to show just the commons widget or interwiki widget if that is all we have. It is extra information for an article that might be low in content. But if it is less likely to happen then perhaps we don't need to worry about it. But I think we should not have any exceptions to the rule. Everything in the preview can be useful by itself to the user.

Yeah with content I meant, everything we show in preview i.e. all the cards on mobile. I think the cards layout was done with these scenario in mind and so I do not think we need to come up with a new one. I think it is okay for preview to be glorified images. I also think it is okay to show just the commons widget or interwiki widget if that is all we have. It is extra information for an article that might be low in content. But if it is less likely to happen then perhaps we don't need to worry about it. But I think we should not have any exceptions to the rule. Everything in the preview can be useful by itself to the user.

Thanks @Sneha. I just updated the acceptance criteria in the description to reflect this.

CBogen renamed this task from Mobile search Preview not shown for articles with existing desktop search preview to [S] Mobile search Preview not shown for articles with existing desktop search preview.Feb 8 2023, 5:38 PM

Change 893498 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Mobile search Preview not shown for articles with existing desktop

https://gerrit.wikimedia.org/r/893498

After a discussion with @Sneha we have agreed to NOT show the snippets if page infos are missing (Description, Thumbnail, sections). This is a change from the current AC that also requires us to wait for the commons request.

We have decide for this change to improve the UX (as the user will have to wait less time) and also because it is going to be extremely unluckily for an article to have no text, no Thumbnail but Commons.

Hi Simone you meant to say "not to show previews if page infos are missing right? (instead of snippets)

Sneha updated the task description. (Show Details)

@SimoneThisDot Also just for future reference, when we implement the expanded snippet we will have to include that in "info content" group as well so that the preview still shows if there is an expanded snippet. Although on mobile the expanded snippet is not placed in preview as it expands in place as shown in this prototype. We can discuss this when we work on the snippet expansion ticket. Just wanted to note it here as it is related to our discussion.

Change 893498 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Mobile search Preview not shown for articles with existing desktop

https://gerrit.wikimedia.org/r/893498

Checked in betalabs - the mobile display works as expected.
Testing note: check for short articles on pilot wikis.