Page MenuHomePhabricator

Section-level images: Create task type
Closed, ResolvedPublic

Description

Add the minimum amount of infrastructure needed for the new task type to appear in the Difficulty Filters dialog

  • TaskType class
  • TaskType handler class
  • Integration in Special:EditGrowthConfig
  • Search keyword
  • i18n messages

image.png (1×1 px, 193 KB)

Acceptance Criteria

  1. section level images can be checked as an option on DifficultyFilters dialog for Suggested Edits

image.png (1×1 px, 193 KB)

Design

Mobile-01-Tasks Onboarding (1).png (640×360 px, 43 KB)

Initial suggested copy:

  • Add an image to an unillustrated article
  • Add an image to an article section

Non goals

  • API (static or production) integration
  • EventBus communication
  • Log formatting for Special:RecentChanges

Event Timeline

kostajh triaged this task as Medium priority.Mar 14 2023, 11:02 AM
kostajh updated the task description. (Show Details)
Sgs changed the task status from Open to In Progress.Mar 27 2023, 4:20 PM

@JFernandez-WMF - it sounds like it would be best if we could finalize language for the task type to unblock @Sgs. Will you update this task description with an updated image and suggested copy?

Here's the most recent Figma design I can find for this:

Mobile-01-Tasks Onboarding.png (640×360 px, 40 KB)

However, my understanding is that we will change that copy slightly based on user testing feedback. My suggestion is below, but feel free to suggest something else. My thinking:

  • adding "unillustrated" helps further differentiate these tasks
  • shortening and removing "suggested" from the task name since "Machine suggested" shows below, and then the task name more closely matches how this feature is documented ("add an image" )

  • Add an image to an unillustrated article

Machine suggestions

  • Add an image to an article section

Machine suggestions

Change 908500 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] [WIP] Section images: create task type

https://gerrit.wikimedia.org/r/908500

Thanks @KStoller-WMF, the initial suggested copy you proposed here sounds good to me! I will update the description with the design and that new copy added.

For now I put it as a medium task and below the Add an image task. Should we also decide if we are continuing with that approach or if we are changing the level of difficulty?

For now I put it as a medium task and below the Add an image task.

For now I think what you've suggested is the best approach. We canalways reconsider in the future once we've completed funnel analysis if we see newcomers struggle with this task far more than the article-level add an image suggestions. Or perhaps after T330784: [M] Another round of manual evaluation for SLIS, if we see the accuracy is much lower than expected, then we might want to move this task to "Hard".

For Add an image task type there are three community configurable fields (aside of the quality gate fields):

  1. Articles containing templates defined here will not be shown to users as tasks for this task type.
  2. Articles containing categories defined here will not be shown to users as tasks for this task type.
  3. Destination page for learning more about image recommendation task type.

Do we want/need to provide support for any of these in the new section image task type?

As per the language considerations, the copy updates sound reasonable. One question is if the update on the existing copy from Add a suggested image to Add an image to an unillustrated article could be treated as a separate change and rolled out before the deployment of "Add a section image". That simplifies the code to display the new copy, otherwise we need to "feature flag" the new copy text for all wikis where Add an image is deployed. What do you think? @KStoller-WMF

For Add an image task type there are three community configurable fields (aside of the quality gate fields):

  1. Articles containing templates defined here will not be shown to users as tasks for this task type.
  2. Articles containing categories defined here will not be shown to users as tasks for this task type.
  3. Destination page for learning more about image recommendation task type.

Do we want/need to provide support for any of these in the new section image task type?

From the community perspective, I imagine communities will appreciate having this level of control. Although I am curious to know how often it's actually unitized. I'll follow up with Ambassadors.
Is it a lot of extra effort to make this possible? I assume that should be a separate task, correct?

As per the language considerations, the copy updates sound reasonable. One question is if the update on the existing copy from Add a suggested image to Add an image to an unillustrated article could be treated as a separate change and rolled out before the deployment of "Add a section image". That simplifies the code to display the new copy, otherwise we need to "feature flag" the new copy text for all wikis where Add an image is deployed. What do you think? @KStoller-WMF

I think it's fine to treat this as a separate change and roll this out soon.

@Sgs - I checked in with Ambassadors about the community configurable fields:

  • Articles containing templates defined here will not be shown to users as tasks for this task type.
  • Articles containing categories defined here will not be shown to users as tasks for this task type.

These are important since it's the main way we can ensure we aren't surfacing featured articles or other articles we don't want to surface to newcomers.

Although this task is focusing on a section, I assume we want the logic for this to still be at the article-level, correct? For example, some sections have specific templates (like: https://en.wikipedia.org/wiki/Template:Empty_section), but I assume we want to consider all templates associated with the article, not just the templates associated with a section. Correct?

  • Destination page for learning more about image recommendation task type.

I don't know if this is needed. It doesn't seem well utilized currently and I would assume most wikis are unlikely to have a separate page for section-level image task documentation.

@Sgs - I checked in with Ambassadors about the community configurable fields:

  • Articles containing templates defined here will not be shown to users as tasks for this task type.
  • Articles containing categories defined here will not be shown to users as tasks for this task type.
  • Destination page for learning more about image recommendation task type.

Thanks for checking, @kostajh mentioned these fields are a default for all task types so we'll keep them for section-level images as well.

@KStoller-WMF, should the copy change from Add a suggested image to Add an image to an unillustrated article show in all the interfaces that currently show Add a suggested image? Or just in the task type selection dialog?

Screenshot 2023-04-26 at 11.53.55.png (1×1 px, 152 KB)
Screenshot 2023-04-26 at 11.54.03.png (1×1 px, 220 KB)
Screenshot 2023-04-26 at 12.36.48.png (1×1 px, 639 KB)

Change 912254 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Add an image: rephrase task type name

https://gerrit.wikimedia.org/r/912254

Thanks for checking, @kostajh mentioned these fields are a default for all task types so we'll keep them for section-level images as well.

Sounds good, thanks!

@KStoller-WMF, should the copy change from Add a suggested image to Add an image to an unillustrated article show in all the interfaces that currently show Add a suggested image? Or just in the task type selection dialog?

Screenshot 2023-04-26 at 11.53.55.png (1×1 px, 152 KB)
Screenshot 2023-04-26 at 11.54.03.png (1×1 px, 220 KB)
Screenshot 2023-04-26 at 12.36.48.png (1×1 px, 639 KB)

Good point. Probably all places unless it messes with formatting? Currently I think these are attached as Restricted Files, so I can't see them.

Good point. Probably all places unless it messes with formatting? Currently I think these are attached as Restricted Files, so I can't see them.

Oopsy, granted permission :)

@Sgs Thanks! Yes, I think we should be consistent and use the same language in all three places. Thank you for thinking of this.
Should I create a separate task for this work?

Change 912933 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Section images: add community configuration settings

https://gerrit.wikimedia.org/r/912933

Should I create a separate task for this work?

I don't think we need a separate task. Given the change is to disambiguate between a article level vs section level suggested images linking the change here can help understand the motivation.

Change 912254 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: rephrase task type name

https://gerrit.wikimedia.org/r/912254

Change 908500 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Section images: create task type

https://gerrit.wikimedia.org/r/908500

Change 912933 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Section images: add community configuration settings

https://gerrit.wikimedia.org/r/912933

Sgs changed the task status from In Progress to Open.May 10 2023, 4:25 PM
Sgs moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

This can be tested in beta enwiki. For enabling the new task type run ge.utils.enableSectionImageRecommendations(); from the newcomers homepage.

Etonkovidova subscribed.

Checked in betalabs:

Designbetalabs
Mobile-01-Tasks Onboarding (1).png (640×360 px, 43 KB)
Desktiop:
Screen Shot 2023-05-31 at 2.21.36 PM.png (1×1 px, 220 KB)
Mobile:
Screen Shot 2023-05-31 at 2.57.35 PM.png (1×760 px, 214 KB)

Note: Based on @Sergio's comment, I checked the references to the section level task. @KStoller-WMF - the wording for the section level image suggestion task references has been finalized? The last screenshot has the same wording for as for adding a lead image to an article.

Screen Shot 2023-05-31 at 2.20.43 PM.png (1×1 px, 229 KB)
Screen Shot 2023-05-31 at 3.04.29 PM.png (1×1 px, 165 KB)
Screen Shot 2023-05-31 at 2.29.18 PM.png (930×1 px, 476 KB)

Change 925702 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Section images: Expand SectionImageRecommendationTaskTypeHandler

https://gerrit.wikimedia.org/r/925702

Change 925702 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Section images: Expand SectionImageRecommendationTaskTypeHandler

https://gerrit.wikimedia.org/r/925702