Page MenuHomePhabricator

Handle deletion of article with associated stories
Closed, ResolvedPublic

Assigned To
Authored By
PWaigi-WMF
Feb 20 2023, 1:38 PM
Referenced Files
F37853428: 2023-09-29_11-03-36.png
Sep 29 2023, 6:19 PM
F37853156: 2023-09-29_09-15-46.png
Sep 29 2023, 4:24 PM
F37853154: 2023-09-29_09-15-12.png
Sep 29 2023, 4:24 PM
F37853150: 2023-09-29_09-17-48.png
Sep 29 2023, 4:24 PM
F37853152: 2023-09-29_09-14-20.png
Sep 29 2023, 4:24 PM
F37672212: Screenshot 2023-09-08 at 9.39.24 AM.png
Sep 8 2023, 2:40 PM
F37672168: Screenshot 2023-09-08 at 9.25.48 AM.png
Sep 8 2023, 2:40 PM
F37625825: image.png
Aug 24 2023, 9:54 AM

Description

Background

How to handle Wikistories when the associated article is deleted. Example.

Design

When an administrator decides to delete a story:

  • Show a checkbox option during the article deletion process to delete associated Wikistories, with the checkbox checked by default.
  • Suggested checkbox message options: a. "Delete associated Wikistories along with this article" b. "Remove Wikistories linked to this article".

When an administrator decides not to delete a story:

Screenshot 2023-04-04 at 12.01.27 PM.png (1×3 px, 3 MB)
  • Display a banner on top of the orphaned story pages on MediaWiki, informing readers about the deletion of the associated article.
  • A banner will have following:

Banner message - "Important! The article linked to this story is no longer available. You may need to delete the story to maintain accuracy."
Banner Styling - Html::errorBox()

Screenshot 2023-04-04 at 12.01.01 PM.png (1×3 px, 2 MB)
  • Prioritize article deletion message when image deletion banner already exists.
  • Add orphaned stories in an archive category.
Test Scenarios
  • Wikistory deletion check box is shown during article deletion process.
  • Checkbox above is selected by default.
  • Orphaned story pages have a display banner shown to readers.
  • Orphaned stories are added to an archive category.
Open questions

Note: After community consultation we would provide an option for readers to report or flag orphaned stories for review, such as a "Report Orphaned Story" or "Flag for Review" button.

Event Timeline

PWaigi-WMF triaged this task as Medium priority.Feb 20 2023, 1:59 PM

In the screenshot below, the yellow warning box indicates that some pages are currently linking to the article about to be deleted. In this case specifically, the links are coming from stories so it is conceivable that the admin about to do the deletion would first go and delete the stories.

Screen Shot 2023-04-04 at 9.43.54 AM.png (1×1 px, 152 KB)

SBisson renamed this task from Displaying article changes to Story creators: when Article no longer exists to Handle deletion of article with associated stories.Apr 18 2023, 2:35 PM

Change 919840 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/Wikistories@master] Handle deletion of article with associated stories

https://gerrit.wikimedia.org/r/919840

missing

Change 919840 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Handle deletion of article with associated stories

https://gerrit.wikimedia.org/r/919840

Here are a few things I noticed while going through the acceptance criteria:

When an administrator decides to delete a story:
Show a checkbox option during the article deletion process to delete associated Wikistories, with the checkbox checked by default.

  • ❌ Checkbox is not checked by default. See image below or use this link for an example

Suggested checkbox message options: a. "Delete associated Wikistories along with this article" b. "Also remove Wikistories linked to this article".

  • ❌ Current message is Delete associated stories? and should instead be one of the above options to add some more context.

Screenshot 2023-08-23 at 3.31.25 PM.png (898×1 px, 125 KB)


When an administrator decides not to delete a story:

Display a banner on top of the orphaned story pages on MediaWiki, informing readers about the deletion of the associated article.
A banner will have following:
Banner message - "Important! The article linked to this story is no longer available. You may need to delete the story to maintain accuracy."
Banner background color - #FDE7E5

Banner border color - #DE3333

Screenshot 2023-08-23 at 3.59.30 PM.png (162×574 px, 25 KB)


Add orphaned stories in an archive category.

  • I am not sure how to test this. Can you please provide some details on where I can see this?

❌ Checkbox is not checked by default. See image below or use this link for an example
❌ Current message is Delete associated stories? and should instead be one of the above options to add some more context.

Good catch, moving this back to dev for the quick update. I will sync with @SGautam_WMF which message to use.

❌ Banner background color / border color

We use the built-in Html::errorBox() method to build the banner, i can confirm this doesn't need to customize.

❓ Add orphaned stories in an archive category.

After delete the article (not the story), you should get this tracking category.

image.png (842×897 px, 635 KB)

Change 952364 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/Wikistories@master] Delete story checkbox follow up

https://gerrit.wikimedia.org/r/952364

Change 952364 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Delete story checkbox follow up

https://gerrit.wikimedia.org/r/952364

When an administrator decides to delete a story:
Show a checkbox option during the article deletion process to delete associated Wikistories, with the checkbox checked by default.

  • Checkbox is now checked by default

Suggested checkbox message options: a. "Delete associated Wikistories along with this article" b. "Also remove Wikistories linked to this article".

  • Message option now reads Remove Wikistories linked to this article which adds some context

Screenshot 2023-09-08 at 9.25.48 AM.png (994×2 px, 153 KB)

Add orphaned stories in an archive category.

Screenshot 2023-09-08 at 9.39.24 AM.png (1×2 px, 867 KB)

❌ Banner background color / border color

We use the built-in Html::errorBox() method to build the banner, i can confirm this doesn't need to customize

❓ If the Banner background color / border color does not need to change, can we just update the Acceptance Criteria?

Add orphaned stories in an archive category.

You are checking the MinervaNeue skin that doesn't show the categories, you should check using the other skin (eg. Vector) on desktop.

❌ Banner background color / border color

We use the built-in Html::errorBox() method to build the banner, i can confirm this doesn't need to customize

❓ If the Banner background color / border color does not need to change, can we just update the Acceptance Criteria?

Done.

@hueitan Minerva Skin does not show categories but what about Timeless Skin since it does not show it too?

Add orphaned stories in an archive category.

You are checking the MinervaNeue skin that doesn't show the categories, you should check using the other skin (eg. Vector) on desktop.

Status: ❌ FAIL
Environment: Beta: 1.41.0-alpha (7463ce2)
OS: macOS Sonoma 14.0
Browser: Chrome 117, Firefox 117, Safari 117, Edge 117
Device: MBA M2
Emulated Device:: N/A
Test Links:
https://en.wikipedia.beta.wmflabs.org/wiki/Story:East_Park

❌AC1: Add orphaned stories in an archive category.- Timeless Skin also does not show categories.

Vector 2022Vector 2010MonobookTimeless
2023-09-29_09-14-20.png (1×2 px, 581 KB)
2023-09-29_09-17-48.png (943×1 px, 501 KB)
2023-09-29_09-15-12.png (933×1 px, 527 KB)
2023-09-29_09-15-46.png (971×1 px, 473 KB)

❌AC1: Add orphaned stories in an archive category.- Timeless Skin also does not show categories.

Vector 2022Vector 2010MonobookTimeless
2023-09-29_09-14-20.png (1×2 px, 581 KB)
2023-09-29_09-17-48.png (943×1 px, 501 KB)
2023-09-29_09-15-12.png (933×1 px, 527 KB)
2023-09-29_09-15-46.png (971×1 px, 473 KB)

This is out of our control, some skins don't show the categories; if you are able to see it on Vector and Monobook, then we are good.

In the Timeless skin the categories are in the left or right sidebar. depending on the screen size (things move around because the layout is responsive). Looks like the right sidebar is cut out in the screenshot because username is not visible either.

@Nikerabbit You are correct about being on the right side for Timeless skin as seen in the screenshot below. Based on what Vaughn tested in https://phabricator.wikimedia.org/T330076#9152604 and what was said in https://phabricator.wikimedia.org/T330076#9211779, I will move this to Done. Thanks for all your work!

✅ Add orphaned stories in an archive category. - Every skin minus Minervanue, which doesn't show categories.

Timeless

2023-09-29_11-03-36.png (972×1 px, 503 KB)