Change 891562 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] CompletionWidget: Avoid double scrollbars

https://gerrit.wikimedia.org/r/891562

Change 891562 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] CompletionWidget: Avoid double scrollbars

https://gerrit.wikimedia.org/r/891562

Change 891596 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (51ac44db2)

https://gerrit.wikimedia.org/r/891596

Change 891596 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (51ac44db2)

https://gerrit.wikimedia.org/r/891596

This works fine now. However, the suggested results isn't scrollable.

Change 893745 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Follow-up I5c0ac857d: Change which clippable element we disable clipping on

https://gerrit.wikimedia.org/r/893745

In T330401#8651111, @EAkinloose wrote:

This works fine now. However, the suggested results isn't scrollable.

We limit the list to 8 results deliberately so this is working fine (there are thousands of matches for "T", for example). However if there is less space the list still isn't scrollable, which the second patch above will fix.

In T330401#8661863, @Esanders wrote:
...However if there is less space the list still isn't scrollable, which the second patch above will fix.

I'm moving this back to Editing QA to verify the second patch Ed wrote in T330401#8660603 to fix this issue described above.

Of course, @EAkinloose, if you've already verified f this second patch, please move this back to "Ready for sign off" and I'll close.

In T330401#8665257, @ppelberg wrote:

In T330401#8661863, @Esanders wrote:
...However if there is less space the list still isn't scrollable, which the second patch above will fix.

I'm moving this back to Editing QA to verify the second patch Ed wrote in T330401#8660603 to fix this issue described above.

Of course, @EAkinloose, if you've already verified f this second patch, please move this back to "Ready for sign off" and I'll close.

This has been verified. I think we can close it.

In T330401#8669532, @EAkinloose wrote:

In T330401#8665257, @ppelberg wrote:

In T330401#8661863, @Esanders wrote:
...However if there is less space the list still isn't scrollable, which the second patch above will fix.

I'm moving this back to Editing QA to verify the second patch Ed wrote in T330401#8660603 to fix this issue described above.

Of course, @EAkinloose, if you've already verified f this second patch, please move this back to "Ready for sign off" and I'll close.

This has been verified. I think we can close it.

Sounds good to me

Change 893745 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Follow-up I5c0ac857d: Change which clippable element we disable clipping on

https://gerrit.wikimedia.org/r/893745

Change 896187 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7e95f6c58)

https://gerrit.wikimedia.org/r/896187

This won't be working on beta until the pullthrough commit above is merged.

Change 896187 merged by DLynch:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7e95f6c58)

https://gerrit.wikimedia.org/r/896187

✅ Single scrollbar in username suggestion. Shows 9 suggestions

See https://photos.app.goo.gl/XxKnUHnFKSGRSva48