Page MenuHomePhabricator

"Show IP" button is too tall causing it to be not vertically centered when using the Timeless skin
Closed, DeclinedPublicBUG REPORT

Assigned To
Authored By
• Dreamy_Jazz
Mar 2 2023, 2:25 AM
Referenced Files
F37088119: image.png
Jun 1 2023, 12:02 PM
F37034467: Screenshot 2023-05-25 at 11.41.06 AM.png
May 25 2023, 2:14 PM
F37034485: Screenshot 2023-05-25 at 11.44.15 AM.png
May 25 2023, 2:14 PM
F37031114: Screenshot 2023-05-24 at 10.36.08 AM.png
May 24 2023, 1:13 PM
F37031115: Screenshot 2023-05-24 at 10.37.19 AM.png
May 24 2023, 1:13 PM
F36992183: image.png
May 11 2023, 12:29 PM
F36992181: image.png
May 11 2023, 12:29 PM
F36887655: image.png
Mar 2 2023, 2:25 AM

Description

Steps to replicate the issue (include links if applicable):

  • Make a test edit using a temporary account
  • Log into an account that can view temporary account IPs (making sure to enable the preference)
  • Enable and use the Timeless skin on this account
  • View the history of the page that the test edit was made on

What happens?:
The "Show IP" button is not vertically centered which seems to cause the user tool links to also move down a bit.

What should have happened instead?:
The button should be a bit shorter so that the text is shown centered with the rest of the content.

Software version (skip for WMF-hosted wikis like Wikipedia):
Latest CheckUser, Timeless skin and core

Other information (browser name/version, screenshots, etc.):
Example on the history page:

image.png (1,411×109 px, 50 KB)

Zoomed in comparison:

Skin (Vector is shown for comparison)Without IP reveal setting enabledWith IP reveal setting enabled
Vector 2022 (as expected)
image.png (2,055×274 px, 56 KB)
image.png (1,846×381 px, 54 KB)
Timeless (where this issue is)
image.png (2,155×648 px, 156 KB)
image.png (2,235×727 px, 172 KB)

Event Timeline

• Dreamy_Jazz renamed this task from "Show IP" button is too tall causing it to be not vertially centered when using the Timeless skin to "Show IP" button is too tall causing it to be not vertically centered when using the Timeless skin.Mar 3 2023, 10:51 AM
• Dreamy_Jazz updated the task description. (Show Details)

Change 918492 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/CheckUser@master] "Show IP" button is too tall causing it to be not vertically centered when using the Timeless skin

https://gerrit.wikimedia.org/r/918492

Here's what I'm seeing:

Before the patch:

image.png (895×106 px, 57 KB)

With the patch:

image.png (913×146 px, 60 KB)

I see no difference with the patch but also no error with the present branch

On Master

Screenshot 2023-05-24 at 10.37.19 AM.png (1,632×126 px, 77 KB)

With this branch

Screenshot 2023-05-24 at 10.36.08 AM.png (1,614×118 px, 69 KB)

Could it be possible that the updates we've made since this ticket was created fixed the bug?

@AGueyte It looks as though the Timeless skin has not loaded properly on your local - the screenshots both look like Vector.

Can you try the following if you haven't already?

Despite following the steps, I still have a good result:

Screenshot 2023-05-25 at 11.44.15 AM.png (2,310×1,456 px, 603 KB)

Screenshot 2023-05-25 at 11.41.06 AM.png (2,746×326 px, 167 KB)

We can no longer reproduce the bug on this ticket. @Dreamy_Jazz is this bug still producible ?

The behaviour for me seems to have been fixed. I see the following:

image.png (1,589×386 px, 47 KB)

While the button text isn't centred inside the background hover for the button, the alignment of the text to other text and the height of the button seems to have been improved. This could probably be closed as fixed by another change.

Change 918492 abandoned by TsepoThoabala:

[mediawiki/extensions/CheckUser@master] "Show IP" button is too tall causing it to be not vertically centered when using the Timeless skin

Reason:

This patch is no longer needed as per https://phabricator.wikimedia.org/T330967#8895142

https://gerrit.wikimedia.org/r/918492