Page MenuHomePhabricator

"Show IP" button on Special:RecentChanges using the MinervaNeue skin placed in the wrong place
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Make a test edit using a temporary account
  • Log into an account that can view temporary accounts and ensure the preference to do this is enabled
  • Switch to the MinervaNeue skin
  • Load Special:RecentChanges and find said edit

What happens?:
The "Show IP" button is placed before the temporary account username and is also not centred with the temporary account username.

What should have happened instead?:
The "Show IP" button should be similar to how it's shown on Vector.

Software version (skip for WMF-hosted wikis like Wikipedia):
Latest MinervaNeue, CheckUser and core code

Other information (browser name/version, screenshots, etc.):

Without rights to see "Show IP"With rights to see "Show IP"
image.png (470×673 px, 41 KB)
image.png (468×663 px, 44 KB)

Event Timeline

Change 912901 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Add Minerva style overrides for temporary account reveal button

https://gerrit.wikimedia.org/r/912901

Testing notes

Quite a few things are misaligned on Special:RecentChanges, and I think it's beyond the scope for this to fix everything, so here's what the patch does:

  • ensures the button is shown after the user link (on the right in LTR)
  • brings the button into vertical alignment
  • makes the margins roughly sensible, though they are still inconsistent depending on whether the user is blocked

gate-and-submit has failed a number of times for unrelated reasons, but this should be merged soon.

Change 912901 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add Minerva style overrides for temporary account reveal button

https://gerrit.wikimedia.org/r/912901

@Tchanders Show IP button is now on the correct side but it's crossing over the rollback edit button as seen below. Also, it's on Recent Changes and Watchlist as seen in https://phabricator.wikimedia.org/T330966#8825021

RecentChanges- Crosses over on the rollback button

T331001_IPMasking_Minerva_Hover_RecentChanges_RollbackEdit.png (731×1 px, 93 KB)

Watchlist- Crosses over on the rollback button

T331001_IPMasking_Minerva_Hover_Watchlist_RollbackEdit.png (695×1 px, 96 KB)

Change 918575 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Fix reveal button on Minerva to avoid overlaps on RecentChanges and Watchlist

https://gerrit.wikimedia.org/r/918575

@GMikesell-WMF Should be fixed by the new patch - moving this back to code review. Thanks for raising.

Change 918575 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Fix reveal button on Minerva to avoid overlaps on RecentChanges and Watchlist

https://gerrit.wikimedia.org/r/918575

@Tchanders I'm not sure if this is fine with you or not. It's better but it's slightly crossing over to the rollback 1 edit button as seen in the screenshots below.

Recent Changes

T331001_IPMasking_Minerva_Hover_RecentChanges_RollbackEdit2.png (830×1 px, 105 KB)

Watchlist

T331001_IPMasking_Minerva_Hover_Watchlist_RollbackEdit2.png (788×1 px, 111 KB)

Thanks @GMikesell-WMF

I think we could tinker with this ad infinitum... We discussed raising the button a bit more in code review, but it then becomes weirdly high on a line without the buttons (see below). Since the layout is so disorderly and fragile anyway, I think we should stop now. We can respond to bugs of course, and others can submit more general fixes.

image.png (361×387 px, 28 KB)

@Tchanders Agreed. Ok sounds good to me. The main thing was to have it in the right location anyways so I will move this to Done since I didn't come across anything else besides the one above. Thanks!