Page MenuHomePhabricator

Editor preference not remembered for logged out users (desktop + en.wiki)
Closed, ResolvedPublic

Description

Behavior

  1. On desktop, while logged out (and preferably in a private window), visit a page like:
  2. Tap any "[ edit ]" link you see on the page
  3. Notice a dialog that asks you to decide whether you'd like to continue editing or switch to the visual editor
  4. Elect to switch to the visual editor
  5. Close the tab you opened in "1." or otherwise end this edit session
    • A) Attempt to edit another page (also on desktop while logged out)
    • B) Visit a red link

❗️ Actual

  1. Notice you land in the source editor as opposed to the visual editor which you would've expected the interface to have remembered

✅ Expected

  1. Notice you land in the visual editor (the editor you lasted used)

Thank you to @stevenwalling for identifying this issue.

Event Timeline

ppelberg renamed this task from Editor preference not set for logged out users (desktop) to Editor preference not set for logged out users (desktop + en.wiki).Mar 7 2023, 6:00 PM
ppelberg updated the task description. (Show Details)
ppelberg added a subscriber: stevenwalling.
Esanders renamed this task from Editor preference not set for logged out users (desktop + en.wiki) to Editor preference not remembered for logged out users (desktop + en.wiki).Mar 7 2023, 6:01 PM

This appears to be caused by the mis-named VisualEditorDisableForAnons preference again.

That preference previously cased T253941.

Change 895810 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Set editor preference even when disableForAnons is set

https://gerrit.wikimedia.org/r/895810

This change will only affect wikis using VisualEditorDisableForAnons, specifically en.wiki, es.wiki & zh.wiki.

Change 895810 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Set editor preference even when disableForAnons is set

https://gerrit.wikimedia.org/r/895810

en.wikipedia.beta.wmflabs.org has the disableForAnons flag set so this can be tested there

EAkinloose subscribed.

✅ Editor preference remembered for logged out users

Tested on enbeta and enwiki

See: T331462#8676748 and T331462#8688047 for wikis where this is expected to work

EAkinloose claimed this task.