Page MenuHomePhabricator

[Regression] VisualEditor not available in WikiEditor's toolbar for logged out users at en.wiki
Closed, ResolvedPublic

Description

This task is about making it so logged out editors of en.wiki are able to switch to the visual editor from within the WikiEditor's editing toolbar.

Background

This change is being made for the following reasons:

  • This change will correct the regression T243723 introduced. [1]
  • We are not aware of any agreements or decisions that specified there not be an affordance for switching editing interfaces within the WikiEditor's editing toolbar for anonymous editors editing en.wiki.
  • In the time between now and when the regression [2] was introduced (the end of February, 2020) [3], we have not seen a stark and sustained decrease in the number of reverted edits made by anonymous editors using the browser, on desktop, at en.wiki. [4]

Behavior

  1. On desktop, visit your favorite en.wiki article while being logged out
  2. Click "Edit"

Actual

  1. ❗️Notice there is no way to switch editing modes within the WikiEditor's toolbar.

Expected

  1. ✅Notice there is a way to switch editing modes within the WikiEditor's toolbar.

Done

  • "Expected" behavior has been implemented.

VE edits over time*
*Logged-out users on desktop (the blue-ish bars at the bottom of the graph) have been making edits since the beginning of 2016 then and have mostly stopped since the beginning of this year.
  1. https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/573722/
  2. https://www.mediawiki.org/wiki/MediaWiki_1.35/wmf.21 landed on en.wiki on 27-Feb-2020
Reverted editsFiltlers

Event Timeline

Change 602408 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[operations/mediawiki-config@master] Set wmgVisualEditorDisableForAnons to false on enwiki and eswiki

https://gerrit.wikimedia.org/r/602408

Change 602408 merged by jenkins-bot:
[operations/mediawiki-config@master] Set wmgVisualEditorDisableForAnons to false on enwiki and eswiki

https://gerrit.wikimedia.org/r/602408

Change 602445 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[operations/mediawiki-config@master] Set wmgVisualEditorDisableForAnons to false on enwiki

https://gerrit.wikimedia.org/r/602445

Change 602445 merged by jenkins-bot:
[operations/mediawiki-config@master] Set wmgVisualEditorDisableForAnons to false on enwiki

https://gerrit.wikimedia.org/r/602445

The patches were reverted, they didn't work as expected:

  • On eswiki, it resulted in an "Editar código" (Edit source) tab appearing for anonymous users, while it was not appearing before
  • On enwiki, it resulted in the tab becoming "Edit source", while it was just "Edit" before

Maybe that is technically correct correct, but I definitely did not expect it to happen. I also checked how the wikis looked in the past using web.archive.org and they did not have those tab changes. So we went back.

I'll try to find a different way to fixing this.

Change 602740 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Make VisualEditorDisableForAnons only hide the tabs, not disable the editor

https://gerrit.wikimedia.org/r/602740

We're going to backport and deploy the patch first before merging it into master, so that we can test it in production during the deployment window.

I'll schedule it for tomorrow's "Morning backport window": https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20200610T1800 (I can't do it right now, because I can't prepare the patches until wmf.36 branch is created)

Change 604138 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.35.0-wmf.35] Make VisualEditorDisableForAnons only hide the tabs, not disable the editor

https://gerrit.wikimedia.org/r/604138

Change 604139 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.35.0-wmf.36] Make VisualEditorDisableForAnons only hide the tabs, not disable the editor

https://gerrit.wikimedia.org/r/604139

Change 604138 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.35.0-wmf.35] Make VisualEditorDisableForAnons only hide the tabs, not disable the editor

https://gerrit.wikimedia.org/r/604138

Mentioned in SAL (#wikimedia-operations) [2020-06-10T18:32:12Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.35/extensions/VisualEditor/: 5f4c609: Make VisualEditorDisableForAnons only hide the tabs, not disable the editor (T253941) (duration: 01m 14s)

Change 604139 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.35.0-wmf.36] Make VisualEditorDisableForAnons only hide the tabs, not disable the editor

https://gerrit.wikimedia.org/r/604139

Mentioned in SAL (#wikimedia-operations) [2020-06-10T18:54:12Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.36/extensions/VisualEditor/: 8958860: Make VisualEditorDisableForAnons only hide the tabs, not disable the editor (T253941) (duration: 01m 07s)

This seems to work as expected now: on English or Spanish Wikipedia I see the switcher again, and I don't see any extra tabs (like with the previous attempt) or any other problems; and on Polish Wiktionary the switcher remains unavailable per the previous fix.

Change 602740 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Make VisualEditorDisableForAnons only hide the tabs, not disable the editor

https://gerrit.wikimedia.org/r/602740