Page MenuHomePhabricator
Create Task
Maniphest T332401

Remove old block error messages from GlobalBlocking extension
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Background

There are two sets of block error messages in GlobalBlocking:

  • globalblocking-ipblocked
  • globalblocking-ipblocked-range
  • globalblocking-ipblocked-xff

...and the newer messages (introduced in T317308, with a different parameter order that works with the BlockErrorFormatter):

  • globalblocking-blockedtext-ip
  • globalblocking-blockedtext-range
  • globalblocking-blockedtext-xff

Both sets of messages are also overridden in WikimediaMessages.

The older messages should be removed from GlobalBlocking, along with their overrides in WikimediaMessages.

If possible, we should also remove the hooks that GlobalBlocking provides for overriding the older messages: GlobalBlockingBlockedIpMsgHook, GlobalBlockingBlockedIpRangeMsgHook and GlobalBlockingBlockedIpXffMsgHook. (We should check that no-one else uses these hooks first.)

Acceptance criteria
  • globalblocking-ipblocked, globalblocking-ipblocked-range and globalblocking-ipblocked-xff (and any messages that they exclusively use) are removed from GlobalBlocking
  • Their overrides are removed from WikimediaMessages
  • Either the hooks are removed from GlobalBlocking, or a task is filed for their removal.
Notes

For context, see GlobalBlocking::getUserBlockDetails

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove now unused message keysmediawiki/extensions/GlobalBlockingmaster+0 -6
Replace references to removed GlobalBlocking message keysanalytics/limn-language-datamaster+2 -2
Remove now unused message keysmediawiki/extensions/WikimediaMessagesmaster+0 -9
Replace mentions to removed GlobalBlocking message keysschemas/event/secondarymaster+5 -5
Replace references to removed GlobalBlocking message keystranslatewikimaster+3 -3
Remove deprecated code in GlobalBlockLookup::getUserBlockDetailsmediawiki/extensions/GlobalBlockingmaster+19 -101
Remove hard-deprecated GlobalBlockingBlocked...Msg hooksmediawiki/extensions/GlobalBlockingmaster+0 -163
Drop hard-deprecated GlobalBlockLookup::getUserBlockErrorsmediawiki/extensions/GlobalBlockingmaster+0 -33
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Mar 17 2023, 2:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2023, 2:54 PM
MarcoAurelio mentioned this in T332402: Remove old block error messages from GlobalBlocking extension.Mar 21 2023, 11:24 AM
Tchanders merged a task: T332402: Remove old block error messages from GlobalBlocking extension.Mar 21 2023, 2:24 PM
Tchanders added a subscriber: MarcoAurelio.
Tchanders mentioned this in T356922: Deprecate unnecessary GlobalBlocking hooks.Feb 13 2024, 5:59 PM
Dreamy_Jazz added a parent task: T356936: Update GlobalBlocking services to support global block on accounts.Feb 14 2024, 1:21 PM
Dreamy_Jazz added a subtask: T356922: Deprecate unnecessary GlobalBlocking hooks.
Dreamy_Jazz removed a parent task: T356936: Update GlobalBlocking services to support global block on accounts.
Tchanders closed subtask T356922: Deprecate unnecessary GlobalBlocking hooks as Resolved.Feb 14 2024, 8:29 PM
Dreamy_Jazz mentioned this in T90095: 'globalblocking-ipblocked' needs gender & grammar support & two date/time splits.Feb 15 2024, 5:40 PM
Xaosflux subscribed.May 1 2024, 1:58 PM
• Pittpowner merged a task: T364686: Double Create Redirect links in Toolbox.May 12 2024, 12:45 PM
• Pittpowner added subscribers: Woshixiaodegou, edwardspec.
edwardspec unsubscribed.May 12 2024, 12:50 PM
Dreamy_Jazz claimed this task.Jul 16 2024, 10:08 PM
Dreamy_Jazz set the point value for this task to 1.
Dreamy_Jazz added projects: Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)).
Dreamy_Jazz subscribed.

Been three months since it was hard deprecated, along with the hard deprecation being in at least one release.

Dreamy_Jazz removed a project: Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)).Jul 16 2024, 10:14 PM
Dreamy_Jazz added a parent task: T17294: Allow globally blocking of accounts.
Dreamy_Jazz added a parent task: T358979: Show global block information on Special:CentralAuth/<username>.Jul 30 2024, 2:59 PM
Dreamy_Jazz removed a parent task: T17294: Allow globally blocking of accounts.
Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)).Jul 31 2024, 7:31 PM
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Jul 31 2024, 8:13 PM
gerritbot added a comment.Jul 31 2024, 8:19 PM

Change #1058687 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Drop hard-deprecated GlobalBlockLookup::getUserBlockErrors

https://gerrit.wikimedia.org/r/1058687

gerritbot added a project: Patch-For-Review.Jul 31 2024, 8:19 PM

Change #1058688 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Remove hard-deprecated GlobalBlockingBlocked...Msg hooks

https://gerrit.wikimedia.org/r/1058688

gerritbot added a comment.Jul 31 2024, 8:19 PM

Change #1058690 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Remove deprecated code in GlobalBlockLookup::getUserBlockDetails

https://gerrit.wikimedia.org/r/1058690

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Jul 31 2024, 8:48 PM
gerritbot added a comment.Jul 31 2024, 9:41 PM

Change #1058687 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Drop hard-deprecated GlobalBlockLookup::getUserBlockErrors

https://gerrit.wikimedia.org/r/1058687

gerritbot added a comment.Jul 31 2024, 9:47 PM

Change #1058688 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Remove hard-deprecated GlobalBlockingBlocked...Msg hooks

https://gerrit.wikimedia.org/r/1058688

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Jul 31 2024, 10:00 PM
gerritbot added a comment.Aug 1 2024, 8:22 AM

Change #1058690 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Remove deprecated code in GlobalBlockLookup::getUserBlockDetails

https://gerrit.wikimedia.org/r/1058690

Maintenance_bot removed a project: Patch-For-Review.Aug 1 2024, 8:30 AM
Dreamy_Jazz moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Aug 1 2024, 10:58 AM

Please check that global blocks continue to work as they did before this ticket for accounts and IP addresses. I suggest verifying with a variety of blocks.

Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Aug 2 2024, 4:30 AM
Djackson-ctr subscribed.

Testing for Global Blocks has been completed, no issues discovered with the implementation of the new code.

Tchanders closed this task as Resolved.Aug 2 2024, 7:56 AM
Dreamy_Jazz reopened this task as Open.Aug 2 2024, 11:33 AM

Forgot to actually remove the relevant message keys from en.json and qqq.json. Reopening.

Dreamy_Jazz moved this task from Done to In Progress on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Aug 2 2024, 11:33 AM
gerritbot added a comment.Aug 2 2024, 11:37 AM

Change #1059299 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Remove now unused message keys

https://gerrit.wikimedia.org/r/1059299

gerritbot added a project: Patch-For-Review.Aug 2 2024, 11:37 AM
gerritbot added a comment.Aug 2 2024, 11:43 AM

Change #1059301 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/WikimediaMessages@master] Remove now unused message keys

https://gerrit.wikimedia.org/r/1059301

gerritbot added a comment.Aug 2 2024, 11:51 AM

Change #1059305 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[translatewiki@master] Replace references to removed GlobalBlocking message keys

https://gerrit.wikimedia.org/r/1059305

gerritbot added a comment.Aug 2 2024, 11:59 AM

Change #1059307 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[schemas/event/secondary@master] Replace mentions to removed GlobalBlocking message keys

https://gerrit.wikimedia.org/r/1059307

gerritbot added a comment.Aug 2 2024, 12:02 PM

Change #1059311 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[analytics/limn-language-data@master] Replace references to removed GlobalBlocking message keys

https://gerrit.wikimedia.org/r/1059311

Dreamy_Jazz added a comment.Aug 2 2024, 12:12 PM

Also created https://gitlab.wikimedia.org/repos/mwbot-rs/mwbot/-/merge_requests/84

gerritbot added a comment.Aug 2 2024, 1:03 PM

Change #1059305 merged by jenkins-bot:

[translatewiki@master] Replace references to removed GlobalBlocking message keys

https://gerrit.wikimedia.org/r/1059305

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Aug 2 2024, 7:27 PM
Tchanders edited projects, added Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)); removed Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)).Aug 5 2024, 9:46 AM
Tchanders moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)) board.
gerritbot added a comment.Aug 12 2024, 4:58 PM

Change #1059307 merged by jenkins-bot:

[schemas/event/secondary@master] Replace mentions to removed GlobalBlocking message keys

https://gerrit.wikimedia.org/r/1059307

gerritbot added a comment.Aug 12 2024, 5:40 PM

Change #1059301 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Remove now unused message keys

https://gerrit.wikimedia.org/r/1059301

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.18; 2024-08-13); removed MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Aug 12 2024, 6:00 PM
gerritbot added a comment.Aug 13 2024, 2:32 PM

Change #1059311 abandoned by Milimetric:

[analytics/limn-language-data@master] Replace references to removed GlobalBlocking message keys

Reason:

Really sorry Dreamy Jazz, this repository should've been archived a long long time ago. Doing so now.

https://gerrit.wikimedia.org/r/1059311

Dreamy_Jazz closed this task as Resolved.Aug 19 2024, 12:16 PM
Dreamy_Jazz moved this task from Needs Review to Done on the Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)) board.

Reclosing this

gerritbot added a comment.Aug 19 2024, 12:24 PM

Change #1059299 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Remove now unused message keys

https://gerrit.wikimedia.org/r/1059299

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.19; 2024-08-20); removed MW-1.43-notes (1.43.0-wmf.18; 2024-08-13).Aug 19 2024, 1:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits