Page MenuHomePhabricator

Avoid showing the Try New Task panel on the history page
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Select a suggested edit task, eg: copyedit
  • Make 5 consecutive edits to trigger the "Try new task" panel
  • While the panel is being shown on top of the article page, click on "View history"

What happens?:
The history page loads and the "Try new task panel" is shown again, including a toast message with a success saved edit message

What should have happened instead?:
The panel should not open, neither should open the PostEditPanel or any toast message with a success saved edit message

Software version (skip for WMF-hosted wikis like Wikipedia):

Tested in beta

Other information (browser name/version, screenshots, etc.):

try_new_task_history.gif (2×1 px, 2 MB)

Event Timeline

KStoller-WMF lowered the priority of this task from High to Medium.Jun 9 2023, 5:10 PM
KStoller-WMF subscribed.

We should try to work on this soon, but I'm moving this to Medium priority: it's certainly not ideal behavior, but it's an edge case and the panel can still be minimized or dismissed.

Cyndymediawiksim changed the task status from Open to In Progress.Jul 19 2023, 1:50 PM
Cyndymediawiksim claimed this task.

Change 941379 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Remove Try New Task panel on the history page

https://gerrit.wikimedia.org/r/941379

After the TryNewTaskPanel is shown we normally show the PostEditPanel with the suggested new tasks. My understanding of this issue is that we don't want neither the repeated "You've saved an edit. Thanks and keep going" and the post edit panel to show here at all. I updated the description cc @Cyndymediawiksim

Change 941379 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove Try New Task panel on the history page

https://gerrit.wikimedia.org/r/941379

Sgs changed the task status from In Progress to Open.Aug 14 2023, 3:51 PM
Sgs moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
Etonkovidova subscribed.

Checked in testwiki wmf.22 - both Try New Task panel and the post-edit dialog are not shown anymore on the history page.