Make AutoLoader::$psr4Namespaces private
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Mar 23 2023, 7:11 PM

Description

	/**
	 * @var string[] Namespace (ends with \) => Path (ends with /)
	 * @internal Will become private in 1.40.
	 */
	public static $psr4Namespaces = self::CORE_NAMESPACES;

We should either make this private (I think it's good, no usages outside this class), or at least update the version it will be made private...

Details

Subject	Repo	Branch	Lines +/-
AutoLoader: Make $psr4Namespaces private (reinstated)	mediawiki/core	master	+1 -2
release: Quibble 1.5.4	integration/quibble	master	+15 -3
jjb: update Quibble jobs to 1.5.4	integration/config	master	+24 -24
dockerfiles: update to Quibble 1.5.4	integration/config	master	+55 -1
Revert "AutoLoader: Make $psr4Namespaces private"	mediawiki/core	master	+2 -1
AutoLoader: Make $psr4Namespaces private	mediawiki/core	master	+1 -2
AutoLoader: Make $psr4Namespaces private	mediawiki/core	REL1_40	+1 -2

Customize query in gerrit

Related Objects

Mentioned In: T333412: mediawiki/vendor can't be updated due to phpunit reporting composer.lock failure
T331280: 🔗 Make sitelink URLs work in CI
T332995: Add integration/quibble to codesearch
Mentioned Here: T331280: 🔗 Make sitelink URLs work in CI
T333412: mediawiki/vendor can't be updated due to phpunit reporting composer.lock failure

Event Timeline

Reedy created this task.Mar 23 2023, 7:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2023, 7:11 PM

Change 902459 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] AutoLoader: Make $psr4Namespaces private

https://gerrit.wikimedia.org/r/902459

Change 902375 had a related patch set uploaded (by Krinkle; author: Reedy):

[mediawiki/core@REL1_40] AutoLoader: Make $psr4Namespaces private

https://gerrit.wikimedia.org/r/902375

Change 902375 merged by jenkins-bot:

[mediawiki/core@REL1_40] AutoLoader: Make $psr4Namespaces private

https://gerrit.wikimedia.org/r/902375

Change 902459 merged by jenkins-bot:

[mediawiki/core@master] AutoLoader: Make $psr4Namespaces private

https://gerrit.wikimedia.org/r/902459

Maintenance_bot removed a project: Patch-For-Review.Mar 23 2023, 7:30 PM

This will break everyone's developer setup of Parsoid, since the recommended way used this property until recently. It broke Patch Demo: https://github.com/MatmaRex/patchdemo/issues/544. You'll get an error like "Fatal error: Uncaught Error: Cannot access private property AutoLoader::$psr4Namespaces". Maybe it'd be nice to deprecate it first… Failing that, I hope people will find this ticket.

Apparently the new way is AutoLoader::registerNamespaces(): https://www.mediawiki.org/w/index.php?title=Parsoid&diff=prev&oldid=5222750

It also broke CI for Parsoid itself. https://gerrit.wikimedia.org/r/c/integration/quibble/+/902517 will fix that, once a new release of CI is made and pushed out.

Change 902603 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] Revert "AutoLoader: Make $psr4Namespaces private"

https://gerrit.wikimedia.org/r/902603

gerritbot added a project: Patch-For-Review.Mar 24 2023, 1:49 PM

Reedy mentioned this in T332995: Add integration/quibble to codesearch.Mar 24 2023, 1:55 PM

Change 902603 merged by jenkins-bot:

[mediawiki/core@master] Revert "AutoLoader: Make $psr4Namespaces private"

https://gerrit.wikimedia.org/r/902603

Maintenance_bot removed a project: Patch-For-Review.Mar 24 2023, 2:10 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.2; 2023-03-27).Mar 24 2023, 3:01 PM

Change 902729 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] Reinstate "AutoLoader: Make $psr4Namespaces private"