Page MenuHomePhabricator
Create Task
Maniphest T333412

mediawiki/vendor can't be updated due to phpunit reporting composer.lock failure
Closed, ResolvedPublic
Actions

Description

As of change 891802 (T330228), patches to update mediawiki/vendor are consistently failing with:

Error: your composer.lock file is not up to date.

Interestingly, it is not reporting which packages are missing or outdated. This appears to be an impossible condition because maintenance/checkComposerLockUpToDate.php (as called from composer phpunit bootstrap), explicilty checks whether the two "problem" arrays are empty.

In addition to not printing out what the problem is, it also appears unfixable. @Reedy and myself have both tried to generate the lock file cleanly and it won't accept it. This is at https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/896656/ (for wikimedia/less.php) and https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/901744/ (wikimedia/minify).

Details

SubjectRepoBranchLines +/-
release: Quibble 1.5.4integration/quibblemaster+15 -3
jjb: update Quibble jobs to 1.5.4integration/configmaster+24 -24
dockerfiles: update to Quibble 1.5.4integration/configmaster+55 -1
Set MW_SKIP_EXTERNAL_DEPENDENCIES for vendor jobsintegration/quibblemaster+41 -9
phpunit: Use error() in CheckComposerLockUpToDate for pre-fatal detailsmediawiki/coremaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Mar 29 2023, 12:02 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 29 2023, 12:02 AM
Krinkle updated the task description. (Show Details)Mar 29 2023, 12:06 AM
Krinkle added subscribers: cscott, kostajh.
Krinkle edited subscribers, added: tstarling; removed: kostajh, cscott.Mar 29 2023, 12:09 AM

With the help of @tstarling, we determined the cause of these two separate issues.

  1. CheckComposerLockUpToDate is using output() instead of error(), thus given quiet=>true, we don't get the important messages right before it.

Once the above is fixed, I'm fairly sure that the failure it tells is simply that during the vendor patch we see composer.json (from core) requiring something that vendor doesn't satisfy. This is expected, since this is the commit changing that very thing. We have a similar kind of check in maintenance/update.php where Quibble passes --skip-external-dependencies for this reason when the CI run is using mediawiki/vendor.

The change that broke vendor CI adds support for an MW_SKIP_EXTERNAL_DEPENDENCIES env variable, that we can set to restore this.

  1. Update Quibble to set MW_SKIP_EXTERNAL_DEPENDENCIES=1 in the same condition where we pass --skip-external-dependencies.
gerritbot added a comment.Mar 29 2023, 12:25 AM

Change 903829 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] phpunit: Use error() in CheckComposerLockUpToDate for pre-fatal details

https://gerrit.wikimedia.org/r/903829

gerritbot added a project: Patch-For-Review.Mar 29 2023, 12:25 AM
gerritbot added a comment.Mar 29 2023, 12:40 AM

Change 903832 had a related patch set uploaded (by Krinkle; author: Krinkle):

[integration/quibble@master] Set MW_SKIP_EXTERNAL_DEPENDENCIES in AbstractPhpUnit for vendor jobs

https://gerrit.wikimedia.org/r/903832

gerritbot added a comment.Mar 29 2023, 1:08 AM

Change 903829 merged by jenkins-bot:

[mediawiki/core@master] phpunit: Use error() in CheckComposerLockUpToDate for pre-fatal details

https://gerrit.wikimedia.org/r/903829

gerritbot added a comment.Mar 30 2023, 1:41 PM

Change 903832 merged by jenkins-bot:

[integration/quibble@master] Set MW_SKIP_EXTERNAL_DEPENDENCIES for vendor jobs

https://gerrit.wikimedia.org/r/903832

Maintenance_bot removed a project: Patch-For-Review.Mar 30 2023, 2:10 PM
gerritbot added a comment.Apr 1 2023, 1:12 AM

Change 904867 had a related patch set uploaded (by Krinkle; author: Krinkle):

[integration/quibble@master] release: Quibble 1.5.4

https://gerrit.wikimedia.org/r/904867

gerritbot added a project: Patch-For-Review.Apr 1 2023, 1:12 AM
gerritbot added a comment.Apr 3 2023, 9:53 AM

Change 905167 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] dockerfiles: update to Quibble 1.5.4

https://gerrit.wikimedia.org/r/905167

gerritbot added a comment.Apr 3 2023, 10:16 AM

Change 904867 merged by jenkins-bot:

[integration/quibble@master] release: Quibble 1.5.4

https://gerrit.wikimedia.org/r/904867

Stashbot mentioned this in T331280: 🔗 Make sitelink URLs work in CI.Apr 3 2023, 10:20 AM
Stashbot mentioned this in T332930: Make AutoLoader::$psr4Namespaces private.

Mentioned in SAL (#wikimedia-releng) [2023-04-03T10:20:03Z] <hashar> Tag Quibble 1.5.4 @ 0a37ce9367672e973b49b8293f57ebffe40abdf6 # T332930 T331280 T333412

gerritbot added a comment.Apr 3 2023, 10:21 AM

Change 905167 merged by jenkins-bot:

[integration/config@master] dockerfiles: update to Quibble 1.5.4

https://gerrit.wikimedia.org/r/905167

gerritbot added a comment.Apr 3 2023, 11:10 AM

Change 905190 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: update Quibble jobs to 1.5.4

https://gerrit.wikimedia.org/r/905190

gerritbot added a comment.Apr 4 2023, 5:05 AM

Change 905190 merged by jenkins-bot:

[integration/config@master] jjb: update Quibble jobs to 1.5.4

https://gerrit.wikimedia.org/r/905190

Maintenance_bot removed a project: Patch-For-Review.Apr 4 2023, 5:10 AM
Jdforrester-WMF subscribed.Apr 10 2023, 3:07 PM

Are we just keeping this open for blame-storming purposes / follow-up to stop this happening again?

AIUI the bug-as-filed has been fixed since CI was switched to the latest Quibble version on Tuesday last week, and I updated and landed the two vendor patches mentioned in the description.

Krinkle closed this task as Resolved.Apr 10 2023, 7:09 PM
Krinkle claimed this task.
In T333412#8768457, @Jdforrester-WMF wrote:

Are we just keeping this open for blame-storming purposes / follow-up to stop this happening again?

No. As per Selena, "this" needs to have an owner. However, realistically that can't happen in the current org structure, resource allocation, and associated politics. By the time that is solved, this task will be long forgotten and nothing but an unrepresentative sample of a larger problem.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL