Page MenuHomePhabricator
Create Task
Maniphest T333339

Warning: SQLPlatform::isWriteQuery fallback to regex (from SpecialRecentChangesLinked)
Closed, ResolvedPublic
Actions

Description

Similar to T332941 and T332942. Special:RecentChangesLinked is using $dbr->query() when it doesn’t even need to.

Details

SubjectRepoBranchLines +/-
SpecialRecentChangesLinked: Use SelectQueryBuilder directlymediawiki/coreREL1_40+5 -6
SpecialRecentChangesLinked: Use SelectQueryBuilder directlymediawiki/corewmf/1.41.0-wmf.2+5 -6
SpecialRecentChangesLinked: Use SelectQueryBuilder directlymediawiki/corewmf/1.41.0-wmf.1+5 -6
SpecialRecentChangesLinked: Use SelectQueryBuilder directlymediawiki/coremaster+5 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 28 2023, 12:26 PM
gerritbot added a comment.Mar 28 2023, 12:27 PM

Change 903637 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@master] SpecialRecentChangesLinked: Use SelectQueryBuilder directly

https://gerrit.wikimedia.org/r/903637

gerritbot added a project: Patch-For-Review.Mar 28 2023, 12:27 PM
gerritbot added a comment.Mar 28 2023, 2:20 PM

Change 903637 merged by jenkins-bot:

[mediawiki/core@master] SpecialRecentChangesLinked: Use SelectQueryBuilder directly

https://gerrit.wikimedia.org/r/903637

Maintenance_bot removed a project: Patch-For-Review.Mar 28 2023, 3:10 PM
Lucas_Werkmeister_WMDE added a comment.Mar 28 2023, 3:30 PM

(Leaving open for backporting to wmf.2, wmf.1, and REL1_40.)

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.3; 2023-04-03).Mar 28 2023, 4:00 PM
gerritbot added a comment.Mar 29 2023, 12:52 PM

Change 904129 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@wmf/1.41.0-wmf.1] SpecialRecentChangesLinked: Use SelectQueryBuilder directly

https://gerrit.wikimedia.org/r/904129

gerritbot added a project: Patch-For-Review.Mar 29 2023, 12:52 PM

Change 904130 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@wmf/1.41.0-wmf.2] SpecialRecentChangesLinked: Use SelectQueryBuilder directly

https://gerrit.wikimedia.org/r/904130

gerritbot added a comment.Mar 29 2023, 1:56 PM

Change 904129 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.1] SpecialRecentChangesLinked: Use SelectQueryBuilder directly

https://gerrit.wikimedia.org/r/904129

Stashbot added a comment.Mar 29 2023, 1:56 PM

Mentioned in SAL (#wikimedia-operations) [2023-03-29T13:56:48Z] <lucaswerkmeister-wmde@deploy2002> Started scap: Backport for [[gerrit:904129|SpecialRecentChangesLinked: Use SelectQueryBuilder directly (T333339)]]

Stashbot added a comment.Mar 29 2023, 1:58 PM

Mentioned in SAL (#wikimedia-operations) [2023-03-29T13:58:10Z] <lucaswerkmeister-wmde@deploy2002> lucaswerkmeister-wmde: Backport for [[gerrit:904129|SpecialRecentChangesLinked: Use SelectQueryBuilder directly (T333339)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.1; 2023-03-20); removed MW-1.41-notes (1.41.0-wmf.3; 2023-04-03).Mar 29 2023, 2:00 PM
Stashbot added a comment.Mar 29 2023, 2:04 PM

Mentioned in SAL (#wikimedia-operations) [2023-03-29T14:04:50Z] <lucaswerkmeister-wmde@deploy2002> Finished scap: Backport for [[gerrit:904129|SpecialRecentChangesLinked: Use SelectQueryBuilder directly (T333339)]] (duration: 08m 02s)

gerritbot added a comment.Mar 29 2023, 2:06 PM

Change 904130 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.2] SpecialRecentChangesLinked: Use SelectQueryBuilder directly

https://gerrit.wikimedia.org/r/904130

Stashbot added a comment.Mar 29 2023, 2:07 PM

Mentioned in SAL (#wikimedia-operations) [2023-03-29T14:07:14Z] <lucaswerkmeister-wmde@deploy2002> Started scap: Backport for [[gerrit:904130|SpecialRecentChangesLinked: Use SelectQueryBuilder directly (T333339)]]

Stashbot added a comment.Mar 29 2023, 2:08 PM

Mentioned in SAL (#wikimedia-operations) [2023-03-29T14:08:37Z] <lucaswerkmeister-wmde@deploy2002> lucaswerkmeister-wmde: Backport for [[gerrit:904130|SpecialRecentChangesLinked: Use SelectQueryBuilder directly (T333339)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet

Maintenance_bot removed a project: Patch-For-Review.Mar 29 2023, 2:10 PM
Stashbot added a comment.Mar 29 2023, 2:14 PM

Mentioned in SAL (#wikimedia-operations) [2023-03-29T14:14:45Z] <lucaswerkmeister-wmde@deploy2002> Finished scap: Backport for [[gerrit:904130|SpecialRecentChangesLinked: Use SelectQueryBuilder directly (T333339)]] (duration: 07m 30s)

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.2; 2023-03-27); removed MW-1.41-notes (1.41.0-wmf.1; 2023-03-20).Mar 29 2023, 3:00 PM
gerritbot added a comment.Mar 29 2023, 3:16 PM

Change 904220 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@REL1_40] SpecialRecentChangesLinked: Use SelectQueryBuilder directly

https://gerrit.wikimedia.org/r/904220

gerritbot added a project: Patch-For-Review.Mar 29 2023, 3:16 PM
gerritbot added a comment.Mar 29 2023, 3:47 PM

Change 904220 merged by jenkins-bot:

[mediawiki/core@REL1_40] SpecialRecentChangesLinked: Use SelectQueryBuilder directly

https://gerrit.wikimedia.org/r/904220

ReleaseTaggerBot added a project: MW-1.40-notes.Mar 29 2023, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 29 2023, 4:10 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Mar 31 2023, 1:37 PM
Lucas_Werkmeister_WMDE claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL