Warning: SQLPlatform::isWriteQuery fallback to regex (from ApiQueryRevisions)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krinkle
	Mar 23 2023, 8:11 PM

Description

@Krinkle wrote:

The immediate reason for the warning is that it is calling query() without indication of whether it is a write query or not, thus requiring Rdbms to perform its legacy regexes on the SQL text to guess it.

However, more important than whether it passes the second parameter of query(), is that it calls query() at all, as this should not be used outside Rdbms internals. It exposes raw SQL and should be avoided in favour of safe interfaces like SelectQueryBuilder or IDatabase::select().

Triggered around 28K/hour. Like the Wikibase violation above, this too is due the API code using IDatabase::unionQueries(). It seems the Rdbms library currently doesn't offer any other way to run union queries.

Wikimedia\Rdbms\Platform\SQLPlatform::isWriteQuery fallback to regex

#0 /srv/mediawiki/php-1.41.0-wmf.1/includes/libs/rdbms/database/Database.php(934): Wikimedia\Rdbms\Platform\SQLPlatform->isWriteQuery(string, integer)
…
#4 /srv/mediawiki/php-1.41.0-wmf.1/includes/api/ApiQueryRevisions.php(261): Wikimedia\Rdbms\DBConnRef->query(string, string)
#5 /srv/mediawiki/php-1.41.0-wmf.1/includes/api/ApiQueryRevisionsBase.php(136): ApiQueryRevisions->run()
#6 /srv/mediawiki/php-1.41.0-wmf.1/includes/api/ApiQuery.php(679): ApiQueryRevisionsBase->execute()
#7 /srv/mediawiki/php-1.41.0-wmf.1/includes/api/ApiMain.php(1906): ApiQuery->execute()
#8 /srv/mediawiki/php-1.41.0-wmf.1/includes/api/ApiMain.php(883): ApiMain->executeAction()
#9 /srv/mediawiki/php-1.41.0-wmf.1/includes/api/ApiMain.php(854): ApiMain->executeActionWithErrorHandling()
#10 /srv/mediawiki/php-1.41.0-wmf.1/api.php(91): ApiMain->execute()
#11 /srv/mediawiki/php-1.41.0-wmf.1/api.php(46): wfApiMain()
#12 /srv/mediawiki/w/api.php(3): require(string)
#13 {main}

Details

Subject	Repo	Branch	Lines +/-
api: Mark query as read-only to avoid regex on SQL	mediawiki/core	REL1_40	+2 -1
api: Mark query as read-only to avoid regex on SQL	mediawiki/core	wmf/1.41.0-wmf.1	+2 -1
api: Mark query as read-only to avoid regex on SQL	mediawiki/core	master	+2 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Ladsgroup	T343098 [epic] Data Persistence Hypothesis WE 3.2.1
Resolved	Ladsgroup	T326181 Stop doing regex on SQL in Database
Resolved	Ladsgroup	T332942 Warning: SQLPlatform::isWriteQuery fallback to regex (from ApiQueryRevisions)

Event Timeline

Krinkle created this task.Mar 23 2023, 8:11 PM

Change 903211 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] api: Mark query as read-only to avoid regex on SQL

https://gerrit.wikimedia.org/r/903211

gerritbot added a project: Patch-For-Review.Mar 27 2023, 8:49 AM

Change 903211 merged by jenkins-bot:

[mediawiki/core@master] api: Mark query as read-only to avoid regex on SQL

https://gerrit.wikimedia.org/r/903211

Maintenance_bot removed a project: Patch-For-Review.Mar 27 2023, 9:30 AM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.2; 2023-03-27).Mar 27 2023, 10:00 AM

larissagaulia moved this task from Inbox, needs triage to Radar on the Performance-Team board.Mar 27 2023, 6:26 PM

larissagaulia edited projects, added Performance-Team (Radar); removed Performance-Team.

Krinkle edited projects, added MediaWiki-Action-API; removed MediaWiki-libs-Rdbms.Mar 27 2023, 6:26 PM

Can this task be closed now?

It got merged today, I'm planning to deploy this tomorrow and until then it shouldn't be closed, otherwise people might see the warning and create it again.

Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.Mar 28 2023, 3:29 AM

Change 903549 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@wmf/1.41.0-wmf.1] api: Mark query as read-only to avoid regex on SQL

https://gerrit.wikimedia.org/r/903549

gerritbot added a project: Patch-For-Review.Mar 28 2023, 10:51 AM

Change 903549 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.1] api: Mark query as read-only to avoid regex on SQL

https://gerrit.wikimedia.org/r/903549

Maintenance_bot removed a project: Patch-For-Review.Mar 28 2023, 11:30 AM

Mentioned in SAL (#wikimedia-operations) [2023-03-28T11:32:57Z] <ladsgroup@deploy2002> Started scap: Backport for [[gerrit:903549|api: Mark query as read-only to avoid regex on SQL (T332942)]]

Mentioned in SAL (#wikimedia-operations) [2023-03-28T11:34:24Z] <ladsgroup@deploy2002> ladsgroup: Backport for [[gerrit:903549|api: Mark query as read-only to avoid regex on SQL (T332942)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-03-28T11:51:40Z] <ladsgroup@deploy2002> Finished scap: Backport for [[gerrit:903549|api: Mark query as read-only to avoid regex on SQL (T332942)]] (duration: 18m 42s)

Ladsgroup closed this task as Resolved.Mar 28 2023, 11:57 AM

Ladsgroup claimed this task.

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.1; 2023-03-20); removed MW-1.41-notes (1.41.0-wmf.2; 2023-03-27).Mar 28 2023, 12:00 PM

Lucas_Werkmeister_WMDE mentioned this in T333339: Warning: SQLPlatform::isWriteQuery fallback to regex (from SpecialRecentChangesLinked).Mar 28 2023, 12:26 PM

Change 904206 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Amir Sarabadani):

[mediawiki/core@REL1_40] api: Mark query as read-only to avoid regex on SQL

https://gerrit.wikimedia.org/r/904206

gerritbot added a project: Patch-For-Review.Mar 29 2023, 2:44 PM

Change 904206 merged by jenkins-bot:

[mediawiki/core@REL1_40] api: Mark query as read-only to avoid regex on SQL

https://gerrit.wikimedia.org/r/904206

Maintenance_bot removed a project: Patch-For-Review.Mar 29 2023, 3:30 PM