Warning: SQLPlatform::isWriteQuery fallback to regex (GoogleNewsSitemap)
Closed, ResolvedPublic
Actions

Description

#4 /srv/mediawiki/php-1.41.0-wmf.2/extensions/GoogleNewsSitemap/includes/Specials/GoogleNewsSitemap.php(304): Wikimedia\Rdbms\DBConnRef->query(string, string)
#5 /srv/mediawiki/php-1.41.0-wmf.2/extensions/GoogleNewsSitemap/includes/Specials/GoogleNewsSitemap.php(140): MediaWiki\Extension\GoogleNewsSitemap\Specials\GoogleNewsSitemap->getCacheInvalidationInfo(array, array, array)

This call to ->query() should either be ported to a different method, or specify one of the ISQLPlatform::QUERY_CHANGE_* constants if that’s not possible.

Details

	Subject	Repo	Branch	Lines +/-
	Use SelectQueryBuilder + UnionQueryBuilder	mediawiki/extensions/GoogleNewsSitemap	master	+15 -13

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	Ladsgroup	T343098 [epic] Data Persistence Hypothesis WE 3.2.1
Resolved	Ladsgroup	T326181 Stop doing regex on SQL in Database
Resolved	Lucas_Werkmeister_WMDE	T333686 Warning: SQLPlatform::isWriteQuery fallback to regex (GoogleNewsSitemap)

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 31 2023, 1:42 PM

Another UNION case, like T332941, T332942 and T333687. (Compare T333690.) Let’s just add the flag for now.

Change 904806 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/GoogleNewsSitemap@master] Mark query as read-only

https://gerrit.wikimedia.org/r/904806

gerritbot added a project: Patch-For-Review.Mar 31 2023, 2:24 PM

Lucas_Werkmeister_WMDE renamed this task from Warning: Wikimedia\Rdbms\Platform\SQLPlatform::isWriteQuery fallback to regex (GoogleNewsSitemap) to Warning: SQLPlatform::isWriteQuery fallback to regex (GoogleNewsSitemap).Mar 31 2023, 2:24 PM

Lucas_Werkmeister_WMDE claimed this task.

Mainframe98 added a project: MediaWiki-extensions-GoogleNewsSitemap.Mar 31 2023, 5:17 PM

larissagaulia moved this task from Inbox, needs triage to Radar on the Performance-Team board.Apr 3 2023, 4:36 PM

larissagaulia edited projects, added Performance-Team (Radar); removed Performance-Team.

Change 904806 merged by jenkins-bot:

[mediawiki/extensions/GoogleNewsSitemap@master] Use SelectQueryBuilder + UnionQueryBuilder

https://gerrit.wikimedia.org/r/904806

Maintenance_bot removed a project: Patch-For-Review.Apr 14 2023, 9:30 AM

Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 14 2023, 9:44 AM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).Apr 14 2023, 10:00 AM